Avoid Comm::Connection leaks when helpers are reconfigured or otherwise closed.

CBDATA_CLASS2 classes must be deleted using C++ delete, not cbdataFree().
cbdataFree() does not call the class destructor.

diff --git a/src/helper.cc b/src/helper.cc
index f554ff64787aef4652df3f4ff5ee1ca9cba4defa..0f3e0415b34282ecd90e2117641067842761e330 100644 (file)
--- a/src/helper.cc
+++ b/src/helper.cc
@@ -750,7 +750,7 @@ helperServerFree(helper_server *srv)
     safe_free(srv->requests);
 
     cbdataReferenceDone(srv->parent);
-    cbdataFree(srv);
+    delete srv;
 }
 
 static void
@@ -812,7 +812,7 @@ helperStatefulServerFree(helper_stateful_server *srv)
 
     cbdataReferenceDone(srv->parent);
 
-    cbdataFree(srv);
+    delete srv;
 }
 
 /// Calls back with a pointer to the buffer with the helper output