PCI/pwrctrl: Fix pci_pwrctrl_is_required() device node leak

The for_each_endpoint_of_node() macro requires calling of_node_put() on the
endpoint node when breaking out of the loop early.

Add of_node_put(endpoint) before the early return to release the reference.

Fixes: cf3287fb2c1f ("PCI/pwrctrl: Ensure that remote endpoint node parent has supply requirement")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Link: https://patch.msgid.link/20260323-pwctrl-v1-1-f5c03a2df7fb@gmail.com

diff --git a/drivers/pci/pwrctrl/core.c b/drivers/pci/pwrctrl/core.c
index 7754baed67f229e90081a802cdba1254c7053d91..97cff5b8ca88525b092447cbfe2b588350b896af 100644 (file)
--- a/drivers/pci/pwrctrl/core.c
+++ b/drivers/pci/pwrctrl/core.c
@@ -299,8 +299,10 @@ static bool pci_pwrctrl_is_required(struct device_node *np)
                        struct device_node *remote __free(device_node) =
                                of_graph_get_remote_port_parent(endpoint);
                        if (remote) {
-                               if (of_pci_supply_present(remote))
+                               if (of_pci_supply_present(remote)) {
+                                       of_node_put(endpoint);
                                        return true;
+                               }
                        }
                }
        }