]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpib: Fix inappropriate ioctl error return
authorDave Penkler <dpenkler@gmail.com>
Sat, 11 Apr 2026 10:20:25 +0000 (12:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 May 2026 11:47:33 +0000 (13:47 +0200)
The driver was returning -ENOTTY in the case the ioctl command
was not recognised. Change it to -EBADRQC.

Fixes: 9dde4559e939 ("staging: gpib: Add GPIB common core driver")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://patch.msgid.link/20260411102025.2000-3-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpib/common/gpib_os.c

index ccb69d0b28bcbef13d05f0bc7f3fb085b333fc77..4c6c43f012c8f38c071f6d7d95efe84c618bb6c1 100644 (file)
@@ -606,7 +606,7 @@ long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg)
        unsigned int minor = iminor(file_inode(filep));
        struct gpib_board *board;
        struct gpib_file_private *file_priv = filep->private_data;
-       long retval = -ENOTTY;
+       long retval = -EBADRQC;
 
        if (minor >= GPIB_MAX_NUM_BOARDS) {
                pr_err("gpib: invalid minor number of device file\n");
@@ -799,7 +799,6 @@ long ibioctl(struct file *filep, unsigned int cmd, unsigned long arg)
                mutex_unlock(&board->big_gpib_mutex);
                return write_ioctl(file_priv, board, arg);
        default:
-               retval = -ENOTTY;
                goto done;
        }