's' must be non NULL, remove test.

122 cleanup:

	CID 1452696 (#1 of 1): Dereference before null check (REVERSE_INULL)
	check_after_deref: Null-checking s suggests that it may be
	null, but it has already been dereferenced on all paths
	leading to the check.

123        if (s != NULL)
124                isc_mem_free(mctx, s);

diff --git a/bin/tests/system/dyndb/driver/driver.c b/bin/tests/system/dyndb/driver/driver.c
index 887c9b5da92d927155756586a8a93ba9ebfe8ea8..27b8a8fc44ee2baefd1aeadd884688ce33289bfb 100644 (file)
--- a/bin/tests/system/dyndb/driver/driver.c
+++ b/bin/tests/system/dyndb/driver/driver.c
@@ -120,8 +120,7 @@ dyndb_init(isc_mem_t *mctx, const char *name, const char *parameters,
        *instp = sample_inst;
 
  cleanup:
-       if (s != NULL)
-               isc_mem_free(mctx, s);
+       isc_mem_free(mctx, s);
        if (argv != NULL)
                isc_mem_put(mctx, argv, argc * sizeof(*argv));