]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
can: mcp251xfd: mcp251xfd_probe(): add missing can_rx_offload_del() in error path
authorMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 2 May 2021 09:34:34 +0000 (11:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 08:29:47 +0000 (10:29 +0200)
[ Upstream commit 4376ea42db8bfcac2bc3a30bba93917244a8c2d4 ]

This patch adds the missing can_rx_offload_del(), that must be called
if mcp251xfd_register() fails.

Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Link: https://lore.kernel.org/r/20210504091838.1109047-1-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c

index ee39e79927efb0fcd67692fd047e30bfc799d1ee..486dbd3357aaa439ccef017053cc37dcd59e76ff 100644 (file)
@@ -2947,10 +2947,12 @@ static int mcp251xfd_probe(struct spi_device *spi)
 
        err = mcp251xfd_register(priv);
        if (err)
-               goto out_free_candev;
+               goto out_can_rx_offload_del;
 
        return 0;
 
+ out_can_rx_offload_del:
+       can_rx_offload_del(&priv->offload);
  out_free_candev:
        spi->max_speed_hz = priv->spi_max_speed_hz_orig;