]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
sctp: Fix double-free introduced by bad backport in 2.6.32.62
authorBen Hutchings <ben@decadent.org.uk>
Sun, 7 Dec 2014 19:59:23 +0000 (19:59 +0000)
committerWilly Tarreau <w@1wt.eu>
Sat, 13 Dec 2014 14:16:18 +0000 (15:16 +0100)
One deletion was omitted from the backport of upstream commit c485658bae87
("net: sctp: fix skb leakage in COOKIE ECHO path of chunk->auth_chunk").

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/sctp/sm_statefuns.c

index d40ff4aabbf4ab8ed1ae148efdb3cae829c8a3aa..1d40672750ce3288bcb1d1e4b6b3b8b0f7e0d63b 100644 (file)
@@ -750,7 +750,6 @@ sctp_disposition_t sctp_sf_do_5_1D_ce(const struct sctp_endpoint *ep,
 
                /* Make sure that we and the peer are AUTH capable */
                if (!sctp_auth_enable || !new_asoc->peer.auth_capable) {
-                       kfree_skb(chunk->auth_chunk);
                        sctp_association_free(new_asoc);
                        return sctp_sf_pdiscard(ep, asoc, type, arg, commands);
                }