]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
Avoid sending back uninitialized memory, use 'ftpmessage' in order to have something...
authorChristophe Jaillet <jailletc36@apache.org>
Tue, 17 Dec 2013 21:18:04 +0000 (21:18 +0000)
committerChristophe Jaillet <jailletc36@apache.org>
Tue, 17 Dec 2013 21:18:04 +0000 (21:18 +0000)
Save 8k of stack by the same time.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1551714 13f79535-47bb-0310-9956-ffa450edef68

modules/proxy/mod_proxy_ftp.c

index 6be17c0d9a11c5ad42df1f7d59bf5c4e1e401aa6..5e9e756f8f03767f41e4730f504938cbc55965c0 100644 (file)
@@ -983,7 +983,6 @@ static int proxy_ftp_handler(request_rec *r, proxy_worker *worker,
     apr_bucket_brigade *bb = apr_brigade_create(p, c->bucket_alloc);
     char *buf, *connectname;
     apr_port_t connectport;
-    char buffer[MAX_STRING_LEN];
     char *ftpmessage = NULL;
     char *path, *strp, *type_suffix, *cwd = NULL;
     apr_uri_t uri;
@@ -1673,7 +1672,7 @@ static int proxy_ftp_handler(request_rec *r, proxy_worker *worker,
                         "Error reading from remote server");
             }
             else if (rc != 200) {
-                return ftp_proxyerror(r, backend, HTTP_BAD_GATEWAY, buffer);
+                return ftp_proxyerror(r, backend, HTTP_BAD_GATEWAY, ftpmessage);
             }
 
             /* signal that we must use the EPRT/PORT loop */