]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: macb: Reinitialize tx/rx queue pointer registers and rx ring during resume
authorKevin Hao <haokexin@gmail.com>
Thu, 12 Mar 2026 08:13:59 +0000 (16:13 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 14 Mar 2026 19:19:47 +0000 (12:19 -0700)
On certain platforms, such as AMD Versal boards, the tx/rx queue pointer
registers are cleared after suspend, and the rx queue pointer register
is also disabled during suspend if WOL is enabled. Previously, we assumed
that these registers would be restored by macb_mac_link_up(). However,
in commit bf9cf80cab81, macb_init_buffers() was moved from
macb_mac_link_up() to macb_open(). Therefore, we should call
macb_init_buffers() to reinitialize the tx/rx queue pointer registers
during resume.

Due to the reset of these two registers, we also need to adjust the
tx/rx rings accordingly. The tx ring will be handled by
gem_shuffle_tx_rings() in macb_mac_link_up(), so we only need to
initialize the rx ring here.

Fixes: bf9cf80cab81 ("net: macb: Fix tx/rx malfunction after phy link down and up")
Reported-by: Quanyang Wang <quanyang.wang@windriver.com>
Signed-off-by: Kevin Hao <haokexin@gmail.com>
Tested-by: Quanyang Wang <quanyang.wang@windriver.com>
Cc: stable@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260312-macb-versal-v1-2-467647173fa4@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cadence/macb_main.c

index 4bdc7ccab7309b40e670709f39a278f203046bb8..033cff5719043e7075503ad85cd3a4ce2d0e3e20 100644 (file)
@@ -5952,8 +5952,18 @@ static int __maybe_unused macb_resume(struct device *dev)
                rtnl_unlock();
        }
 
+       if (!(bp->caps & MACB_CAPS_MACB_IS_EMAC))
+               macb_init_buffers(bp);
+
        for (q = 0, queue = bp->queues; q < bp->num_queues;
             ++q, ++queue) {
+               if (!(bp->caps & MACB_CAPS_MACB_IS_EMAC)) {
+                       if (macb_is_gem(bp))
+                               gem_init_rx_ring(queue);
+                       else
+                               macb_init_rx_ring(queue);
+               }
+
                napi_enable(&queue->napi_rx);
                napi_enable(&queue->napi_tx);
        }