]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
digest_ldap_auth: Fix crash on empty password
authorAmos Jeffries <squid3@treenet.co.nz>
Sat, 24 Nov 2012 03:38:06 +0000 (20:38 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Sat, 24 Nov 2012 03:38:06 +0000 (20:38 -0700)
 Detected by Coverity Scan. Issue 740399

helpers/digest_auth/LDAP/ldap_backend.cc

index f7d9244e0082fdcfa6b040e67910376bc60c4355..744985f8a55b2edde9c89bcae0b3d0fca1fc2392 100644 (file)
@@ -263,7 +263,8 @@ retrydnattr:
             value = values;
             while (*value) {
                 if (encrpass) {
-                    if (strcmp(strtok(*value, delimiter), realm) == 0) {
+                    const char *t = strtok(*value, delimiter);
+                    if (t && strcmp(t, realm) == 0) {
                         password = strtok(NULL, delimiter);
                         break;
                     }