]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: Intel: Skylake: Leave data as is when invoking TLV IPCs
authorCezary Rojewski <cezary.rojewski@intel.com>
Wed, 18 Aug 2021 07:57:33 +0000 (09:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Sep 2021 08:00:51 +0000 (10:00 +0200)
[ Upstream commit 126b3422adc80f29d2129db7f61e0113a8a526c6 ]

Advancing pointer initially fixed issue for some users but caused
regression for others. Leave data as it to make it easier for end users
to adjust their topology files if needed.

Fixes: a8cd7066f042 ("ASoC: Intel: Skylake: Strip T and L from TLV IPCs")
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Tested-by: Lukasz Majczak <lma@semihalf.com>
Link: https://lore.kernel.org/r/20210818075742.1515155-3-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/intel/skylake/skl-topology.c

index c0fdab39e7c281fa2fa880fdf528c0c19c199bca..45b1521e61899b8c95549b97085f75e9de36c404 100644 (file)
@@ -1463,12 +1463,6 @@ static int skl_tplg_tlv_control_set(struct snd_kcontrol *kcontrol,
        struct skl_dev *skl = get_skl_ctx(w->dapm->dev);
 
        if (ac->params) {
-               /*
-                * Widget data is expected to be stripped of T and L
-                */
-               size -= 2 * sizeof(unsigned int);
-               data += 2;
-
                if (size > ac->max)
                        return -EINVAL;
                ac->size = size;