]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: bd70528: Drop BD70528 support
authorMatti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Thu, 27 May 2021 11:59:29 +0000 (14:59 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 1 Jun 2021 13:05:24 +0000 (14:05 +0100)
The only known BD70528 use-cases are such that the PMIC is controlled
from separate MCU which is not running Linux. I am not aware of
any Linux driver users. Furthermore, it seems there is no demand for
this IC. Let's ease the maintenance burden and drop the driver. We can
always add it back if there is sudden need for it.

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Link: https://lore.kernel.org/r/d7271362129edceebc512b49efed9ee7c3efcb6a.1622116622.git.matti.vaittinen@fi.rohmeurope.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/Kconfig
drivers/regulator/Makefile
drivers/regulator/bd70528-regulator.c [deleted file]

index 9aeb32c320aab0d3de90a1ca57a944437d246da0..bc02ea3ea2effd974f26402f8132300a0fd06916 100644 (file)
@@ -193,17 +193,6 @@ config REGULATOR_BCM590XX
          BCM590xx PMUs. This will enable support for the software
          controllable LDO/Switching regulators.
 
-config REGULATOR_BD70528
-       tristate "ROHM BD70528 Power Regulator"
-       depends on MFD_ROHM_BD70528
-       help
-         This driver supports voltage regulators on ROHM BD70528 PMIC.
-         This will enable support for the software controllable buck
-         and LDO regulators.
-
-         This driver can also be built as a module. If so, the module
-         will be called bd70528-regulator.
-
 config REGULATOR_BD71815
        tristate "ROHM BD71815 Power Regulator"
        depends on MFD_ROHM_BD71828
index 580b015296ea2c37bc09bbebc77f5e9fe21e67f2..6a5d55e209d305e6496b3a1256e740b6caa2938c 100644 (file)
@@ -29,7 +29,6 @@ obj-$(CONFIG_REGULATOR_AS3722) += as3722-regulator.o
 obj-$(CONFIG_REGULATOR_ATC260X) += atc260x-regulator.o
 obj-$(CONFIG_REGULATOR_AXP20X) += axp20x-regulator.o
 obj-$(CONFIG_REGULATOR_BCM590XX) += bcm590xx-regulator.o
-obj-$(CONFIG_REGULATOR_BD70528) += bd70528-regulator.o
 obj-$(CONFIG_REGULATOR_BD71815)        += bd71815-regulator.o
 obj-$(CONFIG_REGULATOR_BD71828) += bd71828-regulator.o
 obj-$(CONFIG_REGULATOR_BD718XX) += bd718x7-regulator.o
diff --git a/drivers/regulator/bd70528-regulator.c b/drivers/regulator/bd70528-regulator.c
deleted file mode 100644 (file)
index e6fec70..0000000
+++ /dev/null
@@ -1,278 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-// Copyright (C) 2018 ROHM Semiconductors
-// bd70528-regulator.c ROHM BD70528MWV regulator driver
-
-#include <linux/delay.h>
-#include <linux/err.h>
-#include <linux/interrupt.h>
-#include <linux/kernel.h>
-#include <linux/mfd/rohm-bd70528.h>
-#include <linux/module.h>
-#include <linux/of.h>
-#include <linux/platform_device.h>
-#include <linux/regmap.h>
-#include <linux/regulator/driver.h>
-#include <linux/regulator/machine.h>
-#include <linux/regulator/of_regulator.h>
-#include <linux/slab.h>
-
-static const struct linear_range bd70528_buck1_volts[] = {
-       REGULATOR_LINEAR_RANGE(1200000, 0x00, 0x1, 600000),
-       REGULATOR_LINEAR_RANGE(2750000, 0x2, 0xf, 50000),
-};
-static const struct linear_range bd70528_buck2_volts[] = {
-       REGULATOR_LINEAR_RANGE(1200000, 0x00, 0x1, 300000),
-       REGULATOR_LINEAR_RANGE(1550000, 0x2, 0xd, 50000),
-       REGULATOR_LINEAR_RANGE(3000000, 0xe, 0xf, 300000),
-};
-static const struct linear_range bd70528_buck3_volts[] = {
-       REGULATOR_LINEAR_RANGE(800000, 0x00, 0xd, 50000),
-       REGULATOR_LINEAR_RANGE(1800000, 0xe, 0xf, 0),
-};
-
-/* All LDOs have same voltage ranges */
-static const struct linear_range bd70528_ldo_volts[] = {
-       REGULATOR_LINEAR_RANGE(1650000, 0x0, 0x07, 50000),
-       REGULATOR_LINEAR_RANGE(2100000, 0x8, 0x0f, 100000),
-       REGULATOR_LINEAR_RANGE(2850000, 0x10, 0x19, 50000),
-       REGULATOR_LINEAR_RANGE(3300000, 0x19, 0x1f, 0),
-};
-
-/* Also both LEDs support same voltages */
-static const unsigned int led_volts[] = {
-       20000, 30000
-};
-
-static const unsigned int bd70528_buck_ramp_table[] = {
-       250, 125
-};
-
-static int bd70528_led_set_voltage_sel(struct regulator_dev *rdev,
-                                      unsigned int sel)
-{
-       int ret;
-
-       ret = regulator_is_enabled_regmap(rdev);
-       if (ret < 0)
-               return ret;
-
-       if (ret == 0)
-               return regulator_set_voltage_sel_regmap(rdev, sel);
-
-       dev_err(&rdev->dev,
-               "LED voltage change not allowed when led is enabled\n");
-
-       return -EBUSY;
-}
-
-static const struct regulator_ops bd70528_buck_ops = {
-       .enable = regulator_enable_regmap,
-       .disable = regulator_disable_regmap,
-       .is_enabled = regulator_is_enabled_regmap,
-       .list_voltage = regulator_list_voltage_linear_range,
-       .set_voltage_sel = regulator_set_voltage_sel_regmap,
-       .get_voltage_sel = regulator_get_voltage_sel_regmap,
-       .set_voltage_time_sel = regulator_set_voltage_time_sel,
-       .set_ramp_delay = regulator_set_ramp_delay_regmap,
-};
-
-static const struct regulator_ops bd70528_ldo_ops = {
-       .enable = regulator_enable_regmap,
-       .disable = regulator_disable_regmap,
-       .is_enabled = regulator_is_enabled_regmap,
-       .list_voltage = regulator_list_voltage_linear_range,
-       .set_voltage_sel = regulator_set_voltage_sel_regmap,
-       .get_voltage_sel = regulator_get_voltage_sel_regmap,
-       .set_voltage_time_sel = regulator_set_voltage_time_sel,
-};
-
-static const struct regulator_ops bd70528_led_ops = {
-       .enable = regulator_enable_regmap,
-       .disable = regulator_disable_regmap,
-       .is_enabled = regulator_is_enabled_regmap,
-       .list_voltage = regulator_list_voltage_table,
-       .set_voltage_sel = bd70528_led_set_voltage_sel,
-       .get_voltage_sel = regulator_get_voltage_sel_regmap,
-};
-
-static const struct regulator_desc bd70528_desc[] = {
-       {
-               .name = "buck1",
-               .of_match = of_match_ptr("BUCK1"),
-               .regulators_node = of_match_ptr("regulators"),
-               .id = BD70528_BUCK1,
-               .ops = &bd70528_buck_ops,
-               .type = REGULATOR_VOLTAGE,
-               .linear_ranges = bd70528_buck1_volts,
-               .n_linear_ranges = ARRAY_SIZE(bd70528_buck1_volts),
-               .n_voltages = BD70528_BUCK_VOLTS,
-               .enable_reg = BD70528_REG_BUCK1_EN,
-               .enable_mask = BD70528_MASK_RUN_EN,
-               .vsel_reg = BD70528_REG_BUCK1_VOLT,
-               .vsel_mask = BD70528_MASK_BUCK_VOLT,
-               .ramp_reg = BD70528_REG_BUCK1_VOLT,
-               .ramp_mask = BD70528_MASK_BUCK_RAMP,
-               .ramp_delay_table = bd70528_buck_ramp_table,
-               .n_ramp_values = ARRAY_SIZE(bd70528_buck_ramp_table),
-               .owner = THIS_MODULE,
-       },
-       {
-               .name = "buck2",
-               .of_match = of_match_ptr("BUCK2"),
-               .regulators_node = of_match_ptr("regulators"),
-               .id = BD70528_BUCK2,
-               .ops = &bd70528_buck_ops,
-               .type = REGULATOR_VOLTAGE,
-               .linear_ranges = bd70528_buck2_volts,
-               .n_linear_ranges = ARRAY_SIZE(bd70528_buck2_volts),
-               .n_voltages = BD70528_BUCK_VOLTS,
-               .enable_reg = BD70528_REG_BUCK2_EN,
-               .enable_mask = BD70528_MASK_RUN_EN,
-               .vsel_reg = BD70528_REG_BUCK2_VOLT,
-               .vsel_mask = BD70528_MASK_BUCK_VOLT,
-               .ramp_reg = BD70528_REG_BUCK2_VOLT,
-               .ramp_mask = BD70528_MASK_BUCK_RAMP,
-               .ramp_delay_table = bd70528_buck_ramp_table,
-               .n_ramp_values = ARRAY_SIZE(bd70528_buck_ramp_table),
-               .owner = THIS_MODULE,
-       },
-       {
-               .name = "buck3",
-               .of_match = of_match_ptr("BUCK3"),
-               .regulators_node = of_match_ptr("regulators"),
-               .id = BD70528_BUCK3,
-               .ops = &bd70528_buck_ops,
-               .type = REGULATOR_VOLTAGE,
-               .linear_ranges = bd70528_buck3_volts,
-               .n_linear_ranges = ARRAY_SIZE(bd70528_buck3_volts),
-               .n_voltages = BD70528_BUCK_VOLTS,
-               .enable_reg = BD70528_REG_BUCK3_EN,
-               .enable_mask = BD70528_MASK_RUN_EN,
-               .vsel_reg = BD70528_REG_BUCK3_VOLT,
-               .vsel_mask = BD70528_MASK_BUCK_VOLT,
-               .ramp_reg = BD70528_REG_BUCK3_VOLT,
-               .ramp_mask = BD70528_MASK_BUCK_RAMP,
-               .ramp_delay_table = bd70528_buck_ramp_table,
-               .n_ramp_values = ARRAY_SIZE(bd70528_buck_ramp_table),
-               .owner = THIS_MODULE,
-       },
-       {
-               .name = "ldo1",
-               .of_match = of_match_ptr("LDO1"),
-               .regulators_node = of_match_ptr("regulators"),
-               .id = BD70528_LDO1,
-               .ops = &bd70528_ldo_ops,
-               .type = REGULATOR_VOLTAGE,
-               .linear_ranges = bd70528_ldo_volts,
-               .n_linear_ranges = ARRAY_SIZE(bd70528_ldo_volts),
-               .n_voltages = BD70528_LDO_VOLTS,
-               .enable_reg = BD70528_REG_LDO1_EN,
-               .enable_mask = BD70528_MASK_RUN_EN,
-               .vsel_reg = BD70528_REG_LDO1_VOLT,
-               .vsel_mask = BD70528_MASK_LDO_VOLT,
-               .owner = THIS_MODULE,
-       },
-       {
-               .name = "ldo2",
-               .of_match = of_match_ptr("LDO2"),
-               .regulators_node = of_match_ptr("regulators"),
-               .id = BD70528_LDO2,
-               .ops = &bd70528_ldo_ops,
-               .type = REGULATOR_VOLTAGE,
-               .linear_ranges = bd70528_ldo_volts,
-               .n_linear_ranges = ARRAY_SIZE(bd70528_ldo_volts),
-               .n_voltages = BD70528_LDO_VOLTS,
-               .enable_reg = BD70528_REG_LDO2_EN,
-               .enable_mask = BD70528_MASK_RUN_EN,
-               .vsel_reg = BD70528_REG_LDO2_VOLT,
-               .vsel_mask = BD70528_MASK_LDO_VOLT,
-               .owner = THIS_MODULE,
-       },
-       {
-               .name = "ldo3",
-               .of_match = of_match_ptr("LDO3"),
-               .regulators_node = of_match_ptr("regulators"),
-               .id = BD70528_LDO3,
-               .ops = &bd70528_ldo_ops,
-               .type = REGULATOR_VOLTAGE,
-               .linear_ranges = bd70528_ldo_volts,
-               .n_linear_ranges = ARRAY_SIZE(bd70528_ldo_volts),
-               .n_voltages = BD70528_LDO_VOLTS,
-               .enable_reg = BD70528_REG_LDO3_EN,
-               .enable_mask = BD70528_MASK_RUN_EN,
-               .vsel_reg = BD70528_REG_LDO3_VOLT,
-               .vsel_mask = BD70528_MASK_LDO_VOLT,
-               .owner = THIS_MODULE,
-       },
-       {
-               .name = "ldo_led1",
-               .of_match = of_match_ptr("LDO_LED1"),
-               .regulators_node = of_match_ptr("regulators"),
-               .id = BD70528_LED1,
-               .ops = &bd70528_led_ops,
-               .type = REGULATOR_VOLTAGE,
-               .volt_table = &led_volts[0],
-               .n_voltages = ARRAY_SIZE(led_volts),
-               .enable_reg = BD70528_REG_LED_EN,
-               .enable_mask = BD70528_MASK_LED1_EN,
-               .vsel_reg = BD70528_REG_LED_VOLT,
-               .vsel_mask = BD70528_MASK_LED1_VOLT,
-               .owner = THIS_MODULE,
-       },
-       {
-               .name = "ldo_led2",
-               .of_match = of_match_ptr("LDO_LED2"),
-               .regulators_node = of_match_ptr("regulators"),
-               .id = BD70528_LED2,
-               .ops = &bd70528_led_ops,
-               .type = REGULATOR_VOLTAGE,
-               .volt_table = &led_volts[0],
-               .n_voltages = ARRAY_SIZE(led_volts),
-               .enable_reg = BD70528_REG_LED_EN,
-               .enable_mask = BD70528_MASK_LED2_EN,
-               .vsel_reg = BD70528_REG_LED_VOLT,
-               .vsel_mask = BD70528_MASK_LED2_VOLT,
-               .owner = THIS_MODULE,
-       },
-
-};
-
-static int bd70528_probe(struct platform_device *pdev)
-{
-       int i;
-       struct regulator_config config = {
-               .dev = pdev->dev.parent,
-       };
-
-       config.regmap = dev_get_regmap(pdev->dev.parent, NULL);
-       if (!config.regmap)
-               return -ENODEV;
-
-       for (i = 0; i < ARRAY_SIZE(bd70528_desc); i++) {
-               struct regulator_dev *rdev;
-
-               rdev = devm_regulator_register(&pdev->dev, &bd70528_desc[i],
-                                              &config);
-               if (IS_ERR(rdev)) {
-                       dev_err(&pdev->dev,
-                               "failed to register %s regulator\n",
-                               bd70528_desc[i].name);
-                       return PTR_ERR(rdev);
-               }
-       }
-       return 0;
-}
-
-static struct platform_driver bd70528_regulator = {
-       .driver = {
-               .name = "bd70528-pmic"
-       },
-       .probe = bd70528_probe,
-};
-
-module_platform_driver(bd70528_regulator);
-
-MODULE_AUTHOR("Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>");
-MODULE_DESCRIPTION("BD70528 voltage regulator driver");
-MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:bd70528-pmic");