wrapper.c: return on failure in cgroup_add_all_controllers()

Add missing goto statement, to return on failure, reported by Coverity
tool:

CID 258281 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value:
Assigning value ECGINVAL to ret here, but that stored value is
overwritten before it can be used.

the tool reported about unused ret value, but it turned out that the
NULL ret value is for failed attempt to add a controller to the desired
cgroup and needs bailing out after losing the handle. Fix it by
introducing the goto statement in cgroup_add_all_controllers()

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
TJH: Also fix unrelated grammar error near this change.
(cherry picked from commit 83d64a4474366938e1459403eb0c98c3d3b7ee00)

diff --git a/src/wrapper.c b/src/wrapper.c
index 5d9431f3600a2865c19eb33dcf0803cecb5df700..7dac475b88b24d0cbd1e6e1062604b09a1d51a65 100644 (file)
--- a/src/wrapper.c
+++ b/src/wrapper.c
@@ -120,8 +120,9 @@ int cgroup_add_all_controllers(struct cgroup *cgroup)
                cgc = cgroup_add_controller(cgroup, info.name);
                if (!cgc) {
                        ret = ECGINVAL;
-                       fprintf(stderr, "controller %s can't be add\n",
+                       fprintf(stderr, "controller %s can't be added\n",
                                info.name);
+                       goto end;
                }
 
 next: