]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: SDCA: Add FDL library for XU entities
authorMaciej Strozek <mstrozek@opensource.cirrus.com>
Mon, 20 Oct 2025 15:55:07 +0000 (16:55 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 27 Oct 2025 15:31:24 +0000 (15:31 +0000)
Some instances of the XU Entity have a need for Files to be downloaded
from the Host. In these XUs, there is one instance of a Host to Device
(Consumer) UMP, identified by the FDL_CurrentOwner Control. FDL Library
introduced here implements the FDL flow triggered by FDL_CurrentOwner
irq, which sends a file from SoundWire File Table (SWFT) or from the
firmware directory in specific cases, to the Device FDL UMP.

Currently only Direct method of FDL is implemented.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Link: https://patch.msgid.link/20251020155512.353774-15-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/sdca_fdl.h [new file with mode: 0644]
include/sound/sdca_function.h
sound/soc/sdca/Kconfig
sound/soc/sdca/Makefile
sound/soc/sdca/sdca_fdl.c [new file with mode: 0644]

diff --git a/include/sound/sdca_fdl.h b/include/sound/sdca_fdl.h
new file mode 100644 (file)
index 0000000..8b025af
--- /dev/null
@@ -0,0 +1,58 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * The MIPI SDCA specification is available for public downloads at
+ * https://www.mipi.org/mipi-sdca-v1-0-download
+ *
+ * Copyright (C) 2025 Cirrus Logic, Inc. and
+ *                    Cirrus Logic International Semiconductor Ltd.
+ */
+
+#ifndef __SDCA_FDL_H__
+#define __SDCA_FDL_H__
+
+struct device;
+struct regmap;
+struct sdca_fdl_set;
+struct sdca_function_data;
+struct sdca_interrupt;
+
+/**
+ * struct fdl_state - FDL state structure to keep data between interrupts
+ * @set: Pointer to the FDL set currently being downloaded.
+ * @file_index: Index of the current file being processed.
+ */
+struct fdl_state {
+       struct sdca_fdl_set *set;
+       int file_index;
+};
+
+#define SDCA_CTL_XU_FDLH_COMPLETE      0
+#define SDCA_CTL_XU_FDLH_MORE_FILES    SDCA_CTL_XU_FDLH_SET_IN_PROGRESS
+#define SDCA_CTL_XU_FDLH_FILE_AVAILABLE        (SDCA_CTL_XU_FDLH_TRANSFERRED_FILE | \
+                                        SDCA_CTL_XU_FDLH_SET_IN_PROGRESS)
+#define SDCA_CTL_XU_FDLH_MASK          (SDCA_CTL_XU_FDLH_TRANSFERRED_CHUNK | \
+                                        SDCA_CTL_XU_FDLH_TRANSFERRED_FILE | \
+                                        SDCA_CTL_XU_FDLH_SET_IN_PROGRESS | \
+                                        SDCA_CTL_XU_FDLH_RESET_ACK | \
+                                        SDCA_CTL_XU_FDLH_REQ_ABORT)
+
+#define SDCA_CTL_XU_FDLD_COMPLETE      0
+#define SDCA_CTL_XU_FDLD_FILE_OK       (SDCA_CTL_XU_FDLH_TRANSFERRED_FILE | \
+                                        SDCA_CTL_XU_FDLH_SET_IN_PROGRESS | \
+                                        SDCA_CTL_XU_FDLD_ACK_TRANSFER | \
+                                        SDCA_CTL_XU_FDLD_NEEDS_SET)
+#define SDCA_CTL_XU_FDLD_MORE_FILES_OK (SDCA_CTL_XU_FDLH_SET_IN_PROGRESS | \
+                                        SDCA_CTL_XU_FDLD_ACK_TRANSFER | \
+                                        SDCA_CTL_XU_FDLD_NEEDS_SET)
+#define SDCA_CTL_XU_FDLD_MASK          (SDCA_CTL_XU_FDLD_REQ_RESET | \
+                                        SDCA_CTL_XU_FDLD_REQ_ABORT | \
+                                        SDCA_CTL_XU_FDLD_ACK_TRANSFER | \
+                                        SDCA_CTL_XU_FDLD_NEEDS_SET)
+
+int sdca_fdl_alloc_state(struct sdca_interrupt *interrupt);
+int sdca_fdl_process(struct sdca_interrupt *interrupt);
+
+int sdca_reset_function(struct device *dev, struct sdca_function_data *function,
+                       struct regmap *regmap);
+
+#endif // __SDCA_FDL_H__
index f557206cec83d11220ff2c32e9738f46d2ae253f..99cb978f7099b1fbcb7a2459fd5085227a4244cd 100644 (file)
@@ -285,6 +285,27 @@ enum sdca_xu_controls {
        SDCA_CTL_XU_FDL_STATUS                          = 0x14,
        SDCA_CTL_XU_FDL_SET_INDEX                       = 0x15,
        SDCA_CTL_XU_FDL_HOST_REQUEST                    = 0x16,
+
+       /* FDL Status Host->Device bit definitions */
+       SDCA_CTL_XU_FDLH_TRANSFERRED_CHUNK              = BIT(0),
+       SDCA_CTL_XU_FDLH_TRANSFERRED_FILE               = BIT(1),
+       SDCA_CTL_XU_FDLH_SET_IN_PROGRESS                = BIT(2),
+       SDCA_CTL_XU_FDLH_RESET_ACK                      = BIT(4),
+       SDCA_CTL_XU_FDLH_REQ_ABORT                      = BIT(5),
+       /* FDL Status Device->Host bit definitions */
+       SDCA_CTL_XU_FDLD_REQ_RESET                      = BIT(4),
+       SDCA_CTL_XU_FDLD_REQ_ABORT                      = BIT(5),
+       SDCA_CTL_XU_FDLD_ACK_TRANSFER                   = BIT(6),
+       SDCA_CTL_XU_FDLD_NEEDS_SET                      = BIT(7),
+};
+
+/**
+ * enum sdca_set_index_range - Column definitions UMP SetIndex
+ */
+enum sdca_fdl_set_index_range {
+       SDCA_FDL_SET_INDEX_SET_NUMBER                   = 0,
+       SDCA_FDL_SET_INDEX_FILE_SET_ID                  = 1,
+       SDCA_FDL_SET_INDEX_NCOLS                        = 2,
 };
 
 /**
@@ -569,6 +590,9 @@ enum sdca_entity0_controls {
        SDCA_CTL_ENTITY_0_FUNCTION_NEEDS_INITIALIZATION = BIT(5),
        SDCA_CTL_ENTITY_0_FUNCTION_HAS_BEEN_RESET       = BIT(6),
        SDCA_CTL_ENTITY_0_FUNCTION_BUSY                 = BIT(7),
+
+       /* Function Action Bits */
+       SDCA_CTL_ENTITY_0_RESET_FUNCTION_NOW            = BIT(0),
 };
 
 #define SDCA_CTL_MIC_BIAS_NAME                         "Mic Bias"
index 6a3ba43f26bd9e7d418ad67eaba0f6cbe314a03c..a73920d07073ea05865e4bcf8cce6bffa8696d7d 100644 (file)
@@ -25,6 +25,14 @@ config SND_SOC_SDCA_IRQ
        help
          This option enables support for SDCA IRQs.
 
+config SND_SOC_SDCA_FDL
+       bool "SDCA FDL (File DownLoad) support"
+       depends on SND_SOC_SDCA
+       default y
+       help
+         This option enables support for the File Download using UMP,
+         typically used for downloading firmware to devices.
+
 config SND_SOC_SDCA_OPTIONAL
        def_tristate SND_SOC_SDCA || !SND_SOC_SDCA
 
index a1b24c95cd8c837487915492277b172c389203ef..be911c399bbdeda17d02623b1cc350ae3d6263b0 100644 (file)
@@ -4,5 +4,6 @@ snd-soc-sdca-y := sdca_functions.o sdca_device.o sdca_regmap.o sdca_asoc.o \
                  sdca_ump.o
 snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_HID) += sdca_hid.o
 snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_IRQ) += sdca_interrupts.o
+snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_FDL) += sdca_fdl.o
 
 obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca.o
diff --git a/sound/soc/sdca/sdca_fdl.c b/sound/soc/sdca/sdca_fdl.c
new file mode 100644 (file)
index 0000000..8a15c63
--- /dev/null
@@ -0,0 +1,376 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (C) 2025 Cirrus Logic, Inc. and
+//                    Cirrus Logic International Semiconductor Ltd.
+
+/*
+ * The MIPI SDCA specification is available for public downloads at
+ * https://www.mipi.org/mipi-sdca-v1-0-download
+ */
+
+#include <linux/acpi.h>
+#include <linux/device.h>
+#include <linux/dev_printk.h>
+#include <linux/dmi.h>
+#include <linux/firmware.h>
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/regmap.h>
+#include <linux/sprintf.h>
+#include <linux/soundwire/sdw.h>
+#include <linux/soundwire/sdw_registers.h>
+#include <sound/sdca.h>
+#include <sound/sdca_fdl.h>
+#include <sound/sdca_function.h>
+#include <sound/sdca_interrupts.h>
+#include <sound/sdca_ump.h>
+
+/**
+ * sdca_reset_function - send an SDCA function reset
+ * @dev: Device pointer for error messages.
+ * @function: Pointer to the SDCA Function.
+ * @regmap: Pointer to the SDCA Function regmap.
+ *
+ * Return: Zero on success or a negative error code.
+ */
+int sdca_reset_function(struct device *dev, struct sdca_function_data *function,
+                       struct regmap *regmap)
+{
+       unsigned int reg = SDW_SDCA_CTL(function->desc->adr,
+                                       SDCA_ENTITY_TYPE_ENTITY_0,
+                                       SDCA_CTL_ENTITY_0_FUNCTION_ACTION, 0);
+       unsigned int val, poll_us;
+       int ret;
+
+       ret = regmap_write(regmap, reg, SDCA_CTL_ENTITY_0_RESET_FUNCTION_NOW);
+       if (ret) // Allowed for function reset to not be implemented
+               return 0;
+
+       if (!function->reset_max_delay) {
+               dev_err(dev, "No reset delay specified in DisCo\n");
+               return -EINVAL;
+       }
+
+       poll_us = umin(function->reset_max_delay >> 4, 1000);
+
+       ret = regmap_read_poll_timeout(regmap, reg, val, !val, poll_us,
+                                      function->reset_max_delay);
+       if (ret) {
+               dev_err(dev, "Failed waiting for function reset: %d\n", ret);
+               return ret;
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL_NS(sdca_reset_function, "SND_SOC_SDCA");
+
+static char *fdl_get_sku_filename(struct device *dev,
+                                 struct sdca_fdl_file *fdl_file)
+{
+       struct device *parent = dev;
+       const char *product_vendor;
+       const char *product_sku;
+
+       /*
+        * Try to find pci_dev manually because the card may not be ready to be
+        * used for snd_soc_card_get_pci_ssid yet
+        */
+       while (parent) {
+               if (dev_is_pci(parent)) {
+                       struct pci_dev *pci_dev = to_pci_dev(parent);
+
+                       return kasprintf(GFP_KERNEL, "sdca/%x/%x/%x/%x.bin",
+                                        fdl_file->vendor_id,
+                                        pci_dev->subsystem_vendor,
+                                        pci_dev->subsystem_device,
+                                        fdl_file->file_id);
+               } else {
+                       parent = parent->parent;
+               }
+       }
+
+       product_vendor = dmi_get_system_info(DMI_SYS_VENDOR);
+       if (!product_vendor || !strcmp(product_vendor, "Default string"))
+               product_vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
+       if (!product_vendor || !strcmp(product_vendor, "Default string"))
+               product_vendor = dmi_get_system_info(DMI_CHASSIS_VENDOR);
+       if (!product_vendor)
+               product_vendor = "unknown";
+
+       product_sku = dmi_get_system_info(DMI_PRODUCT_SKU);
+       if (!product_sku || !strcmp(product_sku, "Default string"))
+               product_sku = dmi_get_system_info(DMI_PRODUCT_NAME);
+       if (!product_sku)
+               product_sku = "unknown";
+
+       return kasprintf(GFP_KERNEL, "sdca/%x/%s/%s/%x.bin", fdl_file->vendor_id,
+                        product_vendor, product_sku, fdl_file->file_id);
+}
+
+static int fdl_load_file(struct sdca_interrupt *interrupt,
+                        struct sdca_fdl_set *set, int file_index)
+{
+       struct device *dev = interrupt->dev;
+       struct sdca_fdl_data *fdl_data = &interrupt->function->fdl_data;
+       const struct firmware *firmware = NULL;
+       struct acpi_sw_file *swf = NULL, *tmp;
+       struct sdca_fdl_file *fdl_file;
+       char *disk_filename;
+       int ret;
+       int i;
+
+       if (!set) {
+               dev_err(dev, "request to load SWF with no set\n");
+               return -EINVAL;
+       }
+
+       fdl_file = &set->files[file_index];
+
+       if (fdl_data->swft) {
+               tmp = fdl_data->swft->files;
+               for (i = 0; i < fdl_data->swft->header.length; i += tmp->file_length,
+                    tmp = ACPI_ADD_PTR(struct acpi_sw_file, tmp, tmp->file_length)) {
+                       if (tmp->vendor_id == fdl_file->vendor_id &&
+                           tmp->file_id == fdl_file->file_id) {
+                               dev_dbg(dev, "located SWF in ACPI: %x-%x-%x\n",
+                                       tmp->vendor_id, tmp->file_id,
+                                       tmp->file_version);
+                               swf = tmp;
+                               break;
+                       }
+               }
+       }
+
+       disk_filename = fdl_get_sku_filename(dev, fdl_file);
+       if (!disk_filename)
+               return -ENOMEM;
+
+       dev_dbg(dev, "FDL disk filename: %s\n", disk_filename);
+
+       ret = firmware_request_nowarn(&firmware, disk_filename, dev);
+       kfree(disk_filename);
+       if (ret) {
+               disk_filename = kasprintf(GFP_KERNEL, "sdca/%x/%x.bin",
+                                         fdl_file->vendor_id, fdl_file->file_id);
+               if (!disk_filename)
+                       return -ENOMEM;
+
+               dev_dbg(dev, "FDL disk filename: %s\n", disk_filename);
+
+               ret = firmware_request_nowarn(&firmware, disk_filename, dev);
+               kfree(disk_filename);
+       }
+
+       if (!ret) {
+               tmp = (struct acpi_sw_file *)&firmware->data[0];
+
+               if (firmware->size < sizeof(*tmp) ||
+                   tmp->file_length != firmware->size) {
+                       dev_err(dev, "bad disk SWF size\n");
+               } else if (!swf || swf->file_version <= tmp->file_version) {
+                       dev_dbg(dev, "using SWF from disk: %x-%x-%x\n",
+                               tmp->vendor_id, tmp->file_id, tmp->file_version);
+                       swf = tmp;
+               }
+       }
+
+       if (!swf) {
+               dev_err(dev, "failed to locate SWF\n");
+               return -ENOENT;
+       }
+
+       ret = sdca_ump_write_message(dev, interrupt->device_regmap,
+                                    interrupt->function_regmap,
+                                    interrupt->function, interrupt->entity,
+                                    SDCA_CTL_XU_FDL_MESSAGEOFFSET, fdl_file->fdl_offset,
+                                    SDCA_CTL_XU_FDL_MESSAGELENGTH, swf->data,
+                                    swf->file_length - offsetof(struct acpi_sw_file, data));
+       release_firmware(firmware);
+       return ret;
+}
+
+static struct sdca_fdl_set *fdl_get_set(struct sdca_interrupt *interrupt)
+{
+       struct device *dev = interrupt->dev;
+       struct sdca_fdl_data *fdl_data = &interrupt->function->fdl_data;
+       struct sdca_entity *xu = interrupt->entity;
+       struct sdca_control_range *range;
+       unsigned int val;
+       int i, ret;
+
+       ret = regmap_read(interrupt->function_regmap,
+                         SDW_SDCA_CTL(interrupt->function->desc->adr, xu->id,
+                                      SDCA_CTL_XU_FDL_SET_INDEX, 0),
+                         &val);
+       if (ret < 0) {
+               dev_err(dev, "failed to read FDL set index: %d\n", ret);
+               return NULL;
+       }
+
+       range = sdca_selector_find_range(dev, xu, SDCA_CTL_XU_FDL_SET_INDEX,
+                                        SDCA_FDL_SET_INDEX_NCOLS, 0);
+
+       val = sdca_range_search(range, SDCA_FDL_SET_INDEX_SET_NUMBER,
+                               val, SDCA_FDL_SET_INDEX_FILE_SET_ID);
+
+       for (i = 0; i < fdl_data->num_sets; i++) {
+               if (fdl_data->sets[i].id == val)
+                       return &fdl_data->sets[i];
+       }
+
+       dev_err(dev, "invalid fileset id: %d\n", val);
+       return NULL;
+}
+
+static void fdl_end(struct sdca_interrupt *interrupt)
+{
+       struct fdl_state *fdl_state = interrupt->priv;
+
+       if (!fdl_state->set)
+               return;
+
+       fdl_state->set = NULL;
+
+       dev_dbg(interrupt->dev, "completed FDL process\n");
+}
+
+static int fdl_status_process(struct sdca_interrupt *interrupt, unsigned int status)
+{
+       struct fdl_state *fdl_state = interrupt->priv;
+       int ret;
+
+       switch (status) {
+       case SDCA_CTL_XU_FDLD_NEEDS_SET:
+               dev_dbg(interrupt->dev, "starting FDL process...\n");
+
+               fdl_state->file_index = 0;
+               fdl_state->set = fdl_get_set(interrupt);
+               fallthrough;
+       case SDCA_CTL_XU_FDLD_MORE_FILES_OK:
+               ret = fdl_load_file(interrupt, fdl_state->set, fdl_state->file_index);
+               if (ret) {
+                       fdl_end(interrupt);
+                       return SDCA_CTL_XU_FDLH_REQ_ABORT;
+               }
+
+               return SDCA_CTL_XU_FDLH_FILE_AVAILABLE;
+       case SDCA_CTL_XU_FDLD_FILE_OK:
+               if (!fdl_state->set) {
+                       fdl_end(interrupt);
+                       return SDCA_CTL_XU_FDLH_REQ_ABORT;
+               }
+
+               fdl_state->file_index++;
+
+               if (fdl_state->file_index < fdl_state->set->num_files)
+                       return SDCA_CTL_XU_FDLH_MORE_FILES;
+               fallthrough;
+       case SDCA_CTL_XU_FDLD_COMPLETE:
+               fdl_end(interrupt);
+               return SDCA_CTL_XU_FDLH_COMPLETE;
+       default:
+               fdl_end(interrupt);
+
+               if (status & SDCA_CTL_XU_FDLD_REQ_RESET)
+                       return SDCA_CTL_XU_FDLH_RESET_ACK;
+               else if (status & SDCA_CTL_XU_FDLD_REQ_ABORT)
+                       return SDCA_CTL_XU_FDLH_COMPLETE;
+
+               dev_err(interrupt->dev, "invalid FDL status: %x\n", status);
+               return -EINVAL;
+       }
+}
+
+/**
+ * sdca_fdl_process - Process the FDL state machine
+ * @interrupt: SDCA interrupt structure
+ *
+ * Based on section 13.2.5 Flow Diagram for File Download, Host side.
+ *
+ * Return: Zero on success or a negative error code.
+ */
+int sdca_fdl_process(struct sdca_interrupt *interrupt)
+{
+       struct device *dev = interrupt->dev;
+       struct sdca_entity_xu *xu = &interrupt->entity->xu;
+       unsigned int reg, status;
+       int response, ret;
+
+       ret = sdca_ump_get_owner_host(dev, interrupt->function_regmap,
+                                     interrupt->function, interrupt->entity,
+                                     interrupt->control);
+       if (ret)
+               goto reset_function;
+
+       reg = SDW_SDCA_CTL(interrupt->function->desc->adr, interrupt->entity->id,
+                          SDCA_CTL_XU_FDL_STATUS, 0);
+       ret = regmap_read(interrupt->function_regmap, reg, &status);
+       if (ret < 0) {
+               dev_err(dev, "failed to read FDL status: %d\n", ret);
+               return ret;
+       }
+
+       dev_dbg(dev, "FDL status: %#x\n", status);
+
+       ret = fdl_status_process(interrupt, status);
+       if (ret < 0)
+               goto reset_function;
+
+       response = ret;
+
+       dev_dbg(dev, "FDL response: %#x\n", response);
+
+       ret = regmap_write(interrupt->function_regmap, reg,
+                          response | (status & ~SDCA_CTL_XU_FDLH_MASK));
+       if (ret < 0) {
+               dev_err(dev, "failed to set FDL status signal: %d\n", ret);
+               return ret;
+       }
+
+       ret = sdca_ump_set_owner_device(dev, interrupt->function_regmap,
+                                       interrupt->function, interrupt->entity,
+                                       interrupt->control);
+       if (ret)
+               return ret;
+
+       switch (response) {
+       case SDCA_CTL_XU_FDLH_RESET_ACK:
+               dev_dbg(dev, "FDL request reset\n");
+
+               switch (xu->reset_mechanism) {
+               default:
+                       dev_warn(dev, "Requested reset mechanism not implemented\n");
+                       fallthrough;
+               case SDCA_XU_RESET_FUNCTION:
+                       goto reset_function;
+               }
+       default:
+               return 0;
+       }
+
+reset_function:
+       sdca_reset_function(dev, interrupt->function, interrupt->function_regmap);
+
+       return ret;
+}
+EXPORT_SYMBOL_NS_GPL(sdca_fdl_process, "SND_SOC_SDCA");
+
+/**
+ * sdca_fdl_alloc_state - allocate state for an FDL interrupt
+ * @interrupt: SDCA interrupt structure.
+ *
+ * Return: Zero on success or a negative error code.
+ */
+int sdca_fdl_alloc_state(struct sdca_interrupt *interrupt)
+{
+       struct device *dev = interrupt->dev;
+       struct fdl_state *fdl_state;
+
+       fdl_state = devm_kzalloc(dev, sizeof(struct fdl_state), GFP_KERNEL);
+       if (!fdl_state)
+               return -ENOMEM;
+
+       interrupt->priv = fdl_state;
+
+       return 0;
+}
+EXPORT_SYMBOL_NS_GPL(sdca_fdl_alloc_state, "SND_SOC_SDCA");