[Backport r51220 | neal.norwitz]

It's highly unlikely, though possible for PyEval_Get*() to return NULLs.
So be safe and do an XINCREF.

Klocwork # 221-222.

diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
index bf61640b30ba3ec5e62961f4126320be70c097b2..3ae38f3cec957b606c7b5fb0f606ecfb5947a788 100644 (file)
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -687,7 +687,7 @@ builtin_globals(PyObject *self)
        PyObject *d;
 
        d = PyEval_GetGlobals();
-       Py_INCREF(d);
+       Py_XINCREF(d);
        return d;
 }
 
@@ -1118,7 +1118,7 @@ builtin_locals(PyObject *self)
        PyObject *d;
 
        d = PyEval_GetLocals();
-       Py_INCREF(d);
+       Py_XINCREF(d);
        return d;
 }