]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: dac: ad5791: Fix alignment for DMA saftey
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 May 2022 17:56:35 +0000 (18:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:41:31 +0000 (14:41 +0200)
[ Upstream commit b2d5e9de77c8774a5a6cff59d928f2fa38cbc642 ]

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_DMA_MINALIGN definition.

Fixes: 791bb52a0cd2 ("iio:ad5791: Do not store transfer buffers on the stack")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-56-jic23@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/dac/ad5791.c

index 2b14914b40500629e48c973031b7cafab579203e..ee7e89774d9d4a3ca1ed7d35e636f455e04b02c1 100644 (file)
@@ -95,7 +95,7 @@ struct ad5791_state {
        union {
                __be32 d32;
                u8 d8[4];
-       } data[3] ____cacheline_aligned;
+       } data[3] __aligned(IIO_DMA_MINALIGN);
 };
 
 enum ad5791_supported_device_ids {