strncpy is evil. Don't use it.

diff --git a/src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c b/src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c
index e4cd84f5440a6e56b3b2811249f9360a3b8abd93..50f04da5aec6f53494c045f89567b1e4a7692c07 100644 (file)
--- a/src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c
+++ b/src/modules/rlm_sqlhpwippool/rlm_sqlhpwippool.c
@@ -768,8 +768,7 @@ static int sqlhpwippool_accounting(void *instance, REQUEST *request)
                        }
 
                        nasip.s_addr = vp->vp_ipaddr;
-                       strncpy(nasipstr, inet_ntoa(nasip), sizeof(nasipstr) - 1);
-                       nasipstr[sizeof(nasipstr)] = 0;
+                       strlcpy(nasipstr, inet_ntoa(nasip), sizeof(nasipstr));
 
                        if (!nvp_query(__LINE__, data, sqlsock,
                            "UPDATE `%s`.`ips`, `radacct` "