]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
EDAC/altera: Test the correct error reg offset
authorNiravkumar L Rabara <niravkumar.l.rabara@altera.com>
Fri, 25 Apr 2025 14:26:39 +0000 (07:26 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 May 2025 07:43:50 +0000 (09:43 +0200)
commit 4fb7b8fceb0beebbe00712c3daf49ade0386076a upstream.

Test correct structure member, ecc_cecnt_offset, before using it.

  [ bp: Massage commit message. ]

Fixes: 73bcc942f427 ("EDAC, altera: Add Arria10 EDAC support")
Signed-off-by: Niravkumar L Rabara <niravkumar.l.rabara@altera.com>
Signed-off-by: Matthew Gerlach <matthew.gerlach@altera.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Cc: stable@kernel.org
Link: https://lore.kernel.org/20250425142640.33125-2-matthew.gerlach@altera.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/edac/altera_edac.c

index 8b31cd54bdb6de4a483fca1fbdc1499aa64321bb..3d575aecbb427b651d554097784f034d2d8ec196 100644 (file)
@@ -98,7 +98,7 @@ static irqreturn_t altr_sdram_mc_err_handler(int irq, void *dev_id)
        if (status & priv->ecc_stat_ce_mask) {
                regmap_read(drvdata->mc_vbase, priv->ecc_saddr_offset,
                            &err_addr);
-               if (priv->ecc_uecnt_offset)
+               if (priv->ecc_cecnt_offset)
                        regmap_read(drvdata->mc_vbase,  priv->ecc_cecnt_offset,
                                    &err_count);
                edac_mc_handle_error(HW_EVENT_ERR_CORRECTED, mci, err_count,