we specified dns.rdatatype.NONE instead of dns.rdataclass.NONE in some

update delete operations

Original author: Bob Halley <halley@dnspython.org>
Date: 2004-05-23 06:51:54

diff --git a/ChangeLog b/ChangeLog
index d59bf5523115c2103675b75b82c0ef12466d385c..241509bb1382990baf42ca4fe054417b778f6b18 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2004-05-22  Bob Halley  <halley@dnspython.org>
 
+       * dns/update.py (Update.delete): We erroneously specified a
+       "deleting" value of dns.rdatatype.NONE instead of
+       dns.rdataclass.NONE when the thing being deleted was either an
+       Rdataset instance or an Rdata instance.
+
        * dns/rdtypes/ANY/SSHFP.py: Added support for the proposed SSHFP
        RR type.
 

diff --git a/dns/update.py b/dns/update.py
index 973610eeeb67c8c81a183e224c4e7fa0174fffdd..e35f6b946e32652a094897f5c41cea35543687e0 100644 (file)
--- a/dns/update.py
+++ b/dns/update.py
@@ -141,12 +141,12 @@ class Update(dns.message.Message):
         elif isinstance(args[0], dns.rdataset.Rdataset):
             for rds in args:
                 for rd in rds:
-                    self._add_rr(name, 0, rd, dns.rdatatype.NONE)
+                    self._add_rr(name, 0, rd, dns.rdataclass.NONE)
         else:
             args = list(args)
             if isinstance(args[0], dns.rdata.Rdata):
                 for rd in args:
-                    self._add_rr(name, 0, rd, dns.rdatatype.NONE)
+                    self._add_rr(name, 0, rd, dns.rdataclass.NONE)
             else:
                 rdtype = args.pop(0)
                 if isinstance(rdtype, str):