]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
config.c: Fix strncpy() truncation warning
authorTom Hromatka <tom.hromatka@oracle.com>
Tue, 27 Apr 2021 16:46:24 +0000 (16:46 +0000)
committerTom Hromatka <tom.hromatka@oracle.com>
Tue, 27 Apr 2021 16:46:24 +0000 (16:46 +0000)
Fix the following strncpy() string truncation warning:

In function ‘strncpy’,
    inlined from ‘cgroup_config_create_template_group’ at config.c:1844:5:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ output may be truncated copying 4095 bytes from a string of length 4095 [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/config.c

index ae4f88c80a94812bb6f564d169205a51fd97c26d..7a9b325a660f39d931cdec6f98c50179f3341cde 100644 (file)
@@ -1843,6 +1843,7 @@ int cgroup_config_create_template_group(struct cgroup *cgroup,
                                buffer[sizeof(buffer) - 1] = '\0';
                                strncpy(t_cgroup->name, cgroup->name,
                                        FILENAME_MAX-1);
+                               t_cgroup->name[sizeof(t_cgroup->name) - 1] = '\0';
 
                                ret = cgroup_create_cgroup(t_cgroup, flags);