]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: rtw89: check return value of ieee80211_probereq_get() for RNR
authorPing-Ke Shih <pkshih@realtek.com>
Thu, 19 Sep 2024 08:12:14 +0000 (16:12 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 19:03:43 +0000 (20:03 +0100)
[ Upstream commit 630d5d8f2bf6b340202b6bc2c05d794bbd8e4c1c ]

The return value of ieee80211_probereq_get() might be NULL, so check it
before using to avoid NULL pointer access.

Addresses-Coverity-ID: 1529805 ("Dereference null return value")

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20240919081216.28505-2-pkshih@realtek.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtw89/fw.c

index 13a7c39ceb6f5560292310af0f7260d185db045a..e6bceef691e9bea9d6c6e50bdeb0eb5563f197a4 100644 (file)
@@ -6074,6 +6074,9 @@ static int rtw89_update_6ghz_rnr_chan(struct rtw89_dev *rtwdev,
 
                skb = ieee80211_probereq_get(rtwdev->hw, rtwvif_link->mac_addr,
                                             NULL, 0, req->ie_len);
+               if (!skb)
+                       return -ENOMEM;
+
                skb_put_data(skb, ies->ies[NL80211_BAND_6GHZ], ies->len[NL80211_BAND_6GHZ]);
                skb_put_data(skb, ies->common_ies, ies->common_ie_len);
                hdr = (struct ieee80211_hdr *)skb->data;