]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
tests: Don't change settings.STATIC_URL in the XML-RPC tests
authorDamien Lespiau <damien.lespiau@intel.com>
Tue, 22 Sep 2015 16:11:46 +0000 (17:11 +0100)
committerStephen Finucane <stephen.finucane@intel.com>
Thu, 5 Nov 2015 03:56:28 +0000 (03:56 +0000)
I tracked down a weird bug where the Selenium tests supposed to serve
all static files (.css, .js. ...) weren't doing so when running the
full test suite, but everything was working when running the tests in
isolation.

Turns out one of the other tests was changing settings.STATIC_URL
mid-way without restoring the original value in tearDown() and thus
impacting other tests.

It seems that this change wasn't necessary, the XML-RPC server doesn't
server any static file anyway.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Acked-by: Stephen Finucane <stephen.finucane@intel.com>
patchwork/tests/test_xmlrpc.py

index d37c281d517a3d2a206d0e5f9dadf7bfbce79e69..2c1a18ad93e2909c1138b19e295af1339fab5649 100644 (file)
@@ -31,7 +31,6 @@ class XMLRPCTest(LiveServerTestCase):
     fixtures = ['default_states']
 
     def setUp(self):
-        settings.STATIC_URL = '/'
         self.url = (self.live_server_url +
                     reverse('patchwork.views.xmlrpc.xmlrpc'))
         self.rpc = xmlrpclib.Server(self.url)