core-image-ptest: drop PTEST_EXPECT_FAILURE

This variable setting is not helping people now. Because in practice,
ptest failure warnings on autobuilder are still catched and reported
back to developer.

In addition, setting this value to 1 is sometimes causing confusion for
developers.

As an example, I used 'bitbake core-image-ptest-util-linux:do_testimage'.
It succeeded with warning message. I didn't notice the warning message.
I saw the command succeeded and I tought util-linux ptest is OK. But
in actual fact, the ptest failed. It's the PTEST_EXPECT_FAILURE setting
in this core-image-ptest.bb that is not giving me error.

In summary, a simple erroring out action should be clearer.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/recipes-core/images/core-image-ptest.bb b/meta/recipes-core/images/core-image-ptest.bb
index 017f05f81b72ac0c0aeb32ba34e44e8e693fbbb2..0b1eeb1a580cd8d97c5e6edf5a522cb8b3ffb53c 100644 (file)
--- a/meta/recipes-core/images/core-image-ptest.bb
+++ b/meta/recipes-core/images/core-image-ptest.bb
@@ -41,9 +41,6 @@ QB_MEM:virtclass-mcextend-tcl = "-m 5100"
 
 TEST_SUITES = "ping ssh parselogs ptest"
 
-# Sadly at the moment the full set of ptests is not robust enough and sporadically fails in random places
-PTEST_EXPECT_FAILURE = "1"
-
 python () {
     if not d.getVar("MCNAME"):
         raise bb.parse.SkipRecipe("No class extension set")