Bug 622513 - Email-related regexp checking should be case-insensitive. a=mkanat.

diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm
index 9f118d4a6b71ab3b172c0a693395f4ad2a9606ff..b9434059d3c193431275dddf3c553107c7a32a3f 100644 (file)
--- a/Bugzilla/WebService/User.pm
+++ b/Bugzilla/WebService/User.pm
@@ -95,7 +95,7 @@ sub offer_account_by_email {
     if (!$createexp) {
         ThrowUserError("account_creation_disabled");
     }
-    elsif ($email !~ /$createexp/) {
+    elsif ($email !~ /$createexp/i) {
         ThrowUserError("account_creation_restricted");
     }
 

diff --git a/createaccount.cgi b/createaccount.cgi
index c2941bc4c0077269c03ab88dd90b54d808724a53..db0727adda7e50ede1d1d370b89b0c872ff2e6c8 100755 (executable)
--- a/createaccount.cgi
+++ b/createaccount.cgi
@@ -65,7 +65,7 @@ if (defined($login)) {
     $login = Bugzilla::User->check_login_name_for_creation($login);
     $vars->{'login'} = $login;
 
-    if ($login !~ /$createexp/) {
+    if ($login !~ /$createexp/i) {
         ThrowUserError("account_creation_restricted");
     }
 

diff --git a/template/en/default/admin/params/auth.html.tmpl b/template/en/default/admin/params/auth.html.tmpl
index 8e91e54c0e615d906a501a1df5ed7c14dcee6b8d..2e11dffbce0be8a2e5ccaf56bbfb61564e5bca04 100644 (file)
--- a/template/en/default/admin/params/auth.html.tmpl
+++ b/template/en/default/admin/params/auth.html.tmpl
@@ -120,7 +120,7 @@
                  "the <tt>emailregexp</tt> param to only allow local usernames, " _
                  "but you want the mail to be delivered to username@my.local.hostname.",
 
-  createemailregexp => "This defines the regexp to use for email addresses that are " _
+  createemailregexp => "This defines the (case-insensitive) regexp to use for email addresses that are " _
                        "permitted to self-register using a 'New Account' feature. The " _
                        "default (.*) permits any account matching the emailregexp " _
                        "to be created. If this parameter is left blank, no users " _