]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
test update_nowait - added support in MariaDB-10.3
authorDaniel Black <daniel@mariadb.org>
Sun, 12 Sep 2021 05:17:50 +0000 (01:17 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Thu, 16 Sep 2021 15:24:34 +0000 (11:24 -0400)
<!-- Provide a general summary of your proposed changes in the Title field above -->

MariaDB supported NOWAIT in 10.3.

ref: https://mariadb.com/kb/en/wait-and-nowait/

This pull request is:

- [X] very trivial test change
- [ ] A documentation / typographical error fix
- Good to go, no issue or tests are needed
- [ ] A short code fix
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue.  one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.   one line code fixes without tests will not be accepted.
- [ ] A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: `Fixes: #<issue number>` in the commit message
- please include tests.

**Have a nice day!**

Closes: #7009
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/7009
Pull-request-sha: 4fa750e3d34638be7e9583d849216f6d90ca88fc

Change-Id: I4ee8cf2cf84daf7af3300e6f80671375232fcf02

test/orm/test_versioning.py
test/requirements.py

index 54500e599d6e14dbfff3c8b46f92ad2e7ef9c58f..43a6ea53bb24e281f9ee4e0e40ebb08221f1f754 100644 (file)
@@ -163,6 +163,7 @@ class VersioningTest(fixtures.MappedTest):
             ),
             Column("version_id", Integer, nullable=False),
             Column("value", String(40), nullable=False),
+            test_needs_acid=True,
         )
 
     @classmethod
index 644c01f758ee9526440b1c334e0feba9fe93e5db..221a1dafa208fd71e19e666762ba237120f46de3 100644 (file)
@@ -623,7 +623,7 @@ class DefaultRequirements(SuiteRequirements):
     def update_nowait(self):
         """Target database must support SELECT...FOR UPDATE NOWAIT"""
         return skip_if(
-            ["firebird", "mssql", "mysql", "mariadb", "sqlite", "sybase"],
+            ["firebird", "mssql", "mysql", "mariadb<10.3", "sqlite", "sybase"],
             "no FOR UPDATE NOWAIT support",
         )