m4: Don't enable bash-completion by default

Due to the way that check logic was written we basically enabled
bash completion whenever readline was enabled. This is not right
because it made bash-completion pkg-config module required.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

diff --git a/m4/virt-bash-completion.m4 b/m4/virt-bash-completion.m4
index e1ef58740d3850023cf270e7cae446bc02aea675..c8342176f8bafd8d5d858464430b8f7b7c2598e9 100644 (file)
--- a/m4/virt-bash-completion.m4
+++ b/m4/virt-bash-completion.m4
@@ -30,14 +30,10 @@ AC_DEFUN([LIBVIRT_CHECK_BASH_COMPLETION], [
   AC_REQUIRE([LIBVIRT_CHECK_READLINE])
 
   if test "x$with_readline" != "xyes" ; then
-    if test "x$with_bash_completion" != "xyes" ; then
-      with_bash_completion=no
-    else
+    if test "x$with_bash_completion" = "xyes" ; then
       AC_MSG_ERROR([readline is required for bash completion support])
-    fi
-  else
-    if test "x$with_bash_completion" = "xcheck" ; then
-      with_bash_completion=yes
+    else
+      with_bash_completion=no
     fi
   fi