Use string_view to avoid new string creation...

...in apiCheckQNameAllowedCharacters().

diff --git a/pdns/ws-api.cc b/pdns/ws-api.cc
index 16a9f21e0a63504c394da5d01f20c969f97c8c56..9040853d865a55799810bcc547b2c158a9e92e23 100644 (file)
--- a/pdns/ws-api.cc
+++ b/pdns/ws-api.cc
@@ -357,14 +357,14 @@ string apiZoneNameToId(const ZoneName& dname)
   return identifier;
 }
 
-void apiCheckNameAllowedCharacters(const string& name)
+void apiCheckNameAllowedCharacters(std::string_view name)
 {
   if (name.find_first_not_of("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ01234567890_/.-") != std::string::npos) {
-    throw ApiException("Name '" + name + "' contains unsupported characters");
+    throw ApiException("Name '" + std::string(name) + "' contains unsupported characters");
   }
 }
 
-void apiCheckQNameAllowedCharacters(const string& qname)
+void apiCheckQNameAllowedCharacters(std::string_view qname)
 {
   if (qname.compare(0, 2, "*.") == 0) {
     apiCheckNameAllowedCharacters(qname.substr(2));

diff --git a/pdns/ws-api.hh b/pdns/ws-api.hh
index f07bead1abf3f22cceb9a974c2a7603dfe88f097..76f1ef40775d13928133d4cae4d9779deb41d509 100644 (file)
--- a/pdns/ws-api.hh
+++ b/pdns/ws-api.hh
@@ -34,8 +34,8 @@ void apiServerStatistics(HttpRequest* req, HttpResponse* resp);
 // helpers
 ZoneName apiZoneIdToName(const string& identifier);
 string apiZoneNameToId(const ZoneName& name);
-void apiCheckNameAllowedCharacters(const string& name);
-void apiCheckQNameAllowedCharacters(const string& name);
+void apiCheckNameAllowedCharacters(std::string_view name);
+void apiCheckQNameAllowedCharacters(std::string_view name);
 DNSName apiNameToDNSName(const string& name);
 #if defined(PDNS_AUTH)
 ZoneName apiNameToZoneName(const string& name);