]> git.ipfire.org Git - thirdparty/Chart.js.git/commitdiff
Fix memory leak (#7097)
authorJukka Kurkela <jukka.kurkela@gmail.com>
Thu, 13 Feb 2020 23:42:25 +0000 (01:42 +0200)
committerGitHub <noreply@github.com>
Thu, 13 Feb 2020 23:42:25 +0000 (18:42 -0500)
src/core/core.animator.js
src/core/core.controller.js

index 28565629e45957e4c7fac16fba3b4e35c0d6f108..1da3830391c796b7fcb47f5eb61881219be265a9 100644 (file)
@@ -210,6 +210,14 @@ class Animator {
                anims.items = [];
                this._notify(chart, anims, Date.now(), 'complete');
        }
+
+       /**
+        * Remove chart from Animator
+        * @param {Chart} chart
+        */
+       remove(chart) {
+               return this._charts.delete(chart);
+       }
 }
 
 const instance = new Animator();
index add55549b5343fe499d0d82bd3097cb2381d0747..aca27dc759cb6a4208102fe9418714e402391fc1 100644 (file)
@@ -893,6 +893,7 @@ class Chart {
                let i, ilen;
 
                me.stop();
+               Animator.remove(me);
 
                // dataset controllers need to cleanup associated data
                for (i = 0, ilen = me.data.datasets.length; i < ilen; ++i) {