]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd: Fix a few more NULL pointer dereference in device cleanup
authorMario Limonciello <mario.limonciello@amd.com>
Thu, 5 Mar 2026 15:06:11 +0000 (09:06 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Mar 2026 22:19:14 +0000 (17:19 -0500)
I found a few more paths that cleanup fails due to a NULL version pointer
on unsupported hardware.

Add NULL checks as applicable.

Fixes: 39fc2bc4da00 ("drm/amdgpu: Protect GPU register accesses in powergated state in some paths")
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit f5a05f8414fc10f307eb965f303580c7778f8dd2)
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index 10b10bac8b18ae41340792c23bf6b6dd3cddb7f9..761ee5ebb4f59891b247923652d3db13db513eb2 100644 (file)
@@ -3497,6 +3497,8 @@ static int amdgpu_device_ip_fini_early(struct amdgpu_device *adev)
        int i, r;
 
        for (i = 0; i < adev->num_ip_blocks; i++) {
+               if (!adev->ip_blocks[i].version)
+                       continue;
                if (!adev->ip_blocks[i].version->funcs->early_fini)
                        continue;
 
@@ -3574,6 +3576,8 @@ static int amdgpu_device_ip_fini(struct amdgpu_device *adev)
                if (!adev->ip_blocks[i].status.sw)
                        continue;
 
+               if (!adev->ip_blocks[i].version)
+                       continue;
                if (adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_GMC) {
                        amdgpu_ucode_free_bo(adev);
                        amdgpu_free_static_csa(&adev->virt.csa_obj);
@@ -3600,6 +3604,8 @@ static int amdgpu_device_ip_fini(struct amdgpu_device *adev)
        for (i = adev->num_ip_blocks - 1; i >= 0; i--) {
                if (!adev->ip_blocks[i].status.late_initialized)
                        continue;
+               if (!adev->ip_blocks[i].version)
+                       continue;
                if (adev->ip_blocks[i].version->funcs->late_fini)
                        adev->ip_blocks[i].version->funcs->late_fini(&adev->ip_blocks[i]);
                adev->ip_blocks[i].status.late_initialized = false;