Polish up the diff

diff --git a/src/CommCalls.h b/src/CommCalls.h
index 8d3a9bac11de83ddac0342483c0f8d0a94d9e4a0..93bbafe5e6c7ee728c36f92500fd99a5f980d401 100644 (file)
--- a/src/CommCalls.h
+++ b/src/CommCalls.h
@@ -6,7 +6,6 @@
 #include "comm/forward.h"
 #include "comm_err_t.h"
 #include "MasterXaction.h"
-#include "SBuf.h"
 
 /* CommCalls implement AsyncCall interface for comm_* callbacks.
  * The classes cover two call dialer kinds:
@@ -107,6 +106,8 @@ public:
     bool syncWithComm(); // see CommCommonCbParams::syncWithComm
 };
 
+class SBuf;
+
 // read/write (I/O) parameters
 class CommIoCbParams: public CommCommonCbParams
 {

diff --git a/src/client_side.cc b/src/client_side.cc
index d4b4ddda0b4c069fabbe6efbcd9e07e10a4ef9b8..0fc2df8c3a3e128893665e5cdb79c6e9c829189e 100644 (file)
--- a/src/client_side.cc
+++ b/src/client_side.cc
@@ -3631,7 +3631,8 @@ httpsSslBumpAccessCheckDone(allow_t answer, void *data)
         bool ret = connState->handleReadData(&reqStr);
         if (ret)
             ret = connState->clientParseRequests();
-        else {
+
+        if (!ret) {
             debugs(33, 2, HERE << "Failed to start fake CONNECT request for ssl bumped connection: " << connState->clientConnection);
             connState->clientConnection->close();
         }

diff --git a/src/comm/IoCallback.h b/src/comm/IoCallback.h
index 5d50c095786205b47a09e44447bc6f537b0ecd58..b2574795f5e9d935d0588784464d2edcc409c482 100644 (file)
--- a/src/comm/IoCallback.h
+++ b/src/comm/IoCallback.h
@@ -4,9 +4,10 @@
 #include "base/AsyncCall.h"
 #include "comm/forward.h"
 #include "comm_err_t.h"
-#include "SBuf.h"
 #include "typedefs.h"
 
+class SBuf;
+
 namespace Comm
 {