usb: storage: alauda: Use const for card ID array

The alauda_card_ids array is only read, and not modified.

Declaring data as const makes it easier to see what's going on, and can
prevent unintended writes through placement in a read-only section.

Signed-off-by: Jonathan Neuschäfer <j.ne@posteo.net>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20250228-misc-const-v3-3-09b417ded9c4@posteo.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
index 6263c4e61678e890e0192c5c9dad9b97dbaf0e66..e01f3a42bde4200da245c17abd5299c062868204 100644 (file)
--- a/drivers/usb/storage/alauda.c
+++ b/drivers/usb/storage/alauda.c
@@ -174,7 +174,7 @@ struct alauda_card_info {
        unsigned char zoneshift;        /* 1<<zs blocks per zone */
 };
 
-static struct alauda_card_info alauda_card_ids[] = {
+static const struct alauda_card_info alauda_card_ids[] = {
        /* NAND flash */
        { 0x6e, 20, 8, 4, 8},   /* 1 MB */
        { 0xe8, 20, 8, 4, 8},   /* 1 MB */
@@ -200,7 +200,7 @@ static struct alauda_card_info alauda_card_ids[] = {
        { 0,}
 };
 
-static struct alauda_card_info *alauda_card_find_id(unsigned char id)
+static const struct alauda_card_info *alauda_card_find_id(unsigned char id)
 {
        int i;
 
@@ -383,7 +383,7 @@ static int alauda_init_media(struct us_data *us)
 {
        unsigned char *data = us->iobuf;
        int ready = 0;
-       struct alauda_card_info *media_info;
+       const struct alauda_card_info *media_info;
        unsigned int num_zones;
 
        while (ready == 0) {
@@ -1132,7 +1132,7 @@ static int alauda_transport(struct scsi_cmnd *srb, struct us_data *us)
        int rc;
        struct alauda_info *info = (struct alauda_info *) us->extra;
        unsigned char *ptr = us->iobuf;
-       static unsigned char inquiry_response[36] = {
+       static const unsigned char inquiry_response[36] = {
                0x00, 0x80, 0x00, 0x01, 0x1F, 0x00, 0x00, 0x00
        };