]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: pegasus_notetaker - use HID defines
authorOliver Neukum <oneukum@suse.com>
Wed, 25 Mar 2026 14:32:47 +0000 (15:32 +0100)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 25 Mar 2026 16:09:51 +0000 (09:09 -0700)
The driver uses its own definitions for HID requests.
This leads to duplication and obfuscation. Use HID's
definitions.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Link: https://patch.msgid.link/20260325143256.371854-2-oneukum@suse.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/tablet/pegasus_notetaker.c

index 4ce20befc6572b3803f957693e0b41b344ab7c81..85390ae423076fe1e8a1531666f79ef01d463ffd 100644 (file)
@@ -36,6 +36,7 @@
  * T   Tip
  */
 
+#include <linux/hid.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/input.h>
 #include <linux/workqueue.h>
 #include <linux/mutex.h>
 
-/* USB HID defines */
-#define USB_REQ_GET_REPORT             0x01
-#define USB_REQ_SET_REPORT             0x09
-
 #define USB_VENDOR_ID_PEGASUSTECH      0x0e20
 #define USB_DEVICE_ID_PEGASUS_NOTETAKER_EN100  0x0101
 
@@ -108,7 +105,7 @@ static int pegasus_control_msg(struct pegasus *pegasus, u8 *data, int len)
 
        result = usb_control_msg(pegasus->usbdev,
                                 usb_sndctrlpipe(pegasus->usbdev, 0),
-                                USB_REQ_SET_REPORT,
+                                HID_REQ_SET_REPORT,
                                 USB_TYPE_VENDOR | USB_DIR_OUT,
                                 0, 0, cmd_buf, sizeof_buf,
                                 USB_CTRL_SET_TIMEOUT);