]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
gccrs: Implement missing read-only checker case for TuplePatternItemsHasRest
authorYap Zhi Heng <yapzhhg@gmail.com>
Thu, 28 Aug 2025 03:26:03 +0000 (11:26 +0800)
committerArthur Cohen <arthur.cohen@embecosm.com>
Thu, 30 Oct 2025 19:59:06 +0000 (20:59 +0100)
gcc/rust/ChangeLog:

* checks/errors/rust-readonly-check.cc (collect_assignment_tuple): Implement
read-only checker for tuple patterns with rest pattern.

Signed-off-by: Yap Zhi Heng <yapzhhg@gmail.com>
gcc/rust/checks/errors/rust-readonly-check.cc
gcc/testsuite/rust/compile/tuplepattern-rest-readonly.rs [new file with mode: 0644]

index ed4145e564875b0b9da0bcb30ec247a7c7e04947..f484047e60b87b3fd77d47a4bf4d689a4aa64f25 100644 (file)
@@ -144,14 +144,24 @@ ReadonlyChecker::collect_assignment_tuple (TuplePattern &tuple_pattern,
     {
     case HIR::TuplePatternItems::ItemType::NO_REST:
       {
-       auto &items = static_cast<HIR::TuplePatternItemsNoRest &> (
+       auto &items_no_rest = static_cast<HIR::TuplePatternItemsNoRest &> (
          tuple_pattern.get_items ());
-       for (auto &sub : items.get_patterns ())
+       for (auto &sub : items_no_rest.get_patterns ())
          {
            collect_assignment (*sub, has_init_expr);
          }
       }
       break;
+    case HIR::TuplePatternItems::ItemType::HAS_REST:
+      {
+       auto &items_has_rest = static_cast<HIR::TuplePatternItemsHasRest &> (
+         tuple_pattern.get_items ());
+       for (auto &sub : items_has_rest.get_lower_patterns ())
+         collect_assignment (*sub, has_init_expr);
+       for (auto &sub : items_has_rest.get_upper_patterns ())
+         collect_assignment (*sub, has_init_expr);
+      }
+      break;
     default:
       break;
     }
diff --git a/gcc/testsuite/rust/compile/tuplepattern-rest-readonly.rs b/gcc/testsuite/rust/compile/tuplepattern-rest-readonly.rs
new file mode 100644 (file)
index 0000000..db165ef
--- /dev/null
@@ -0,0 +1,5 @@
+fn main() {
+    let (a, .., b) = (1, 1);
+    a = 2; // { dg-error "assignment of read-only variable .a." }
+    b = 2; // { dg-error "assignment of read-only variable .b." }
+}
\ No newline at end of file