codegen: Guard pointer indirection of lengths when returning arrays

Fixes bug 638415.

diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index 1277cd190a5c6b88f082e3832da1266638f696b6..b4efc50087a6706a84a32053743c24d1baffdacc 100644 (file)
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -3191,11 +3191,13 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
 
                        for (int dim = 1; dim <= array_type.rank; dim++) {
                                var len_l = get_result_cexpression (get_array_length_cname ("result", dim));
+                               ccode.open_if (len_l);
                                if (!is_in_coroutine ()) {
                                        len_l = new CCodeUnaryExpression (CCodeUnaryOperator.POINTER_INDIRECTION, len_l);
                                }
                                var len_r = get_array_length_cexpression (stmt.return_expression, dim);
                                ccode.add_assignment (len_l, len_r);
+                               ccode.close ();
                        }
 
                        set_cvalue (stmt.return_expression, get_variable_cexpression (return_expr_decl.name));

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 1f8fec7df6d955f03b7281b9876c6dfae6428c47..013585efe236c9a02955762fa439309c006ad981 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -57,6 +57,7 @@ TESTS = \
        delegates/delegates.vala \
        delegates/bug595610.vala \
        delegates/bug595639.vala \
+       delegates/bug638415.vala \
        delegates/bug639751.vala \
        objects/classes.vala \
        objects/fields.vala \

diff --git a/tests/delegates/bug638415.vala b/tests/delegates/bug638415.vala
new file mode 100644 (file)
index 0000000..2e98842
--- /dev/null
+++ b/tests/delegates/bug638415.vala
@@ -0,0 +1,12 @@
+[CCode (array_length = false)]
+public delegate string[] Deleg ();
+
+string[] foo () {
+       return new string[0];
+}
+
+void main () {
+       Deleg bar = foo;
+       bar ();
+}
+