]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mm/damon/reclaim: reset enabled when DAMON start failed
authorSeongJae Park <sj@kernel.org>
Sun, 6 Jul 2025 19:32:05 +0000 (12:32 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 13 Jul 2025 23:38:34 +0000 (16:38 -0700)
When the startup fails, 'enabled' parameter is not reset.  As a result,
users show the parameter 'Y' while it is not really working.  Fix it by
resetting 'enabled' to 'false' when the work is failed.

Link: https://lkml.kernel.org/r/20250706193207.39810-5-sj@kernel.org
Fixes: 04e98764befa ("mm/damon/reclaim: enable and disable synchronously")
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/reclaim.c

index a675150965e020065d3c6ffbfd77d5dc991c01e6..c91098d8aa51abeffd3da99490c1b9e7c9f74326 100644 (file)
@@ -329,7 +329,7 @@ static int __init damon_reclaim_init(void)
        int err = damon_modules_new_paddr_ctx_target(&ctx, &target);
 
        if (err)
-               return err;
+               goto out;
 
        ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check;
        ctx->callback.after_aggregation = damon_reclaim_after_aggregation;
@@ -338,6 +338,9 @@ static int __init damon_reclaim_init(void)
        if (enabled)
                err = damon_reclaim_turn(true);
 
+out:
+       if (err && enabled)
+               enabled = false;
        return err;
 }