]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi-geni-qcom: initialize mode related registers to 0
authorJonathan Marek <jonathan@marek.ca>
Thu, 20 Nov 2025 21:12:01 +0000 (16:12 -0500)
committerMark Brown <broonie@kernel.org>
Sun, 14 Dec 2025 10:39:24 +0000 (19:39 +0900)
setup_fifo_params assumes these will be zero, it won't write these
registers if the initial mode is zero.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Link: https://patch.msgid.link/20251120211204.24078-4-jonathan@marek.ca
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-geni-qcom.c

index 575b112d4acb1df1f6b3f5339675a55204439a18..53229150b86b55ee641ce826cb3842e186283ae4 100644 (file)
@@ -675,6 +675,12 @@ static int spi_geni_init(struct spi_geni_master *mas)
        case 0:
                mas->cur_xfer_mode = GENI_SE_FIFO;
                geni_se_select_mode(se, GENI_SE_FIFO);
+               /* setup_fifo_params assumes that these registers start with a zero value */
+               writel(0, se->base + SE_SPI_LOOPBACK);
+               writel(0, se->base + SE_SPI_DEMUX_SEL);
+               writel(0, se->base + SE_SPI_CPHA);
+               writel(0, se->base + SE_SPI_CPOL);
+               writel(0, se->base + SE_SPI_DEMUX_OUTPUT_INV);
                ret = 0;
                break;
        }