]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
meson: Enable ZFS storage backend more often
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 14 Sep 2021 07:38:44 +0000 (09:38 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 21 Sep 2021 12:10:03 +0000 (14:10 +0200)
Currently, the ZFS storage backend is enabled only if both zfs
and zpool binaries were found during configure phase. This is not
consistent with our attempts to move dependencies on binaries
from compile to runtime. And also it is inconsistent with other
backends, e.g. vstorage.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
meson.build

index 77ee60977db83792a478a1aa19131d0cce15a0d6..488490181fb918de6c7eb2b49f8dbb08d2b8cdf8 100644 (file)
@@ -1947,24 +1947,24 @@ if conf.has('WITH_LIBVIRTD')
   endif
 
   if not get_option('storage_zfs').disabled()
-    zfs_enable = true
     foreach name : [ 'zfs', 'zpool' ]
       set_variable(
         '@0@_prog'.format(name),
         find_program(name, required: get_option('storage_zfs'), dirs: libvirt_sbin_path)
       )
-      if not get_variable('@0@_prog'.format(name)).found()
-        zfs_enable = false
-      endif
     endforeach
 
-    if zfs_enable
-      use_storage = true
-      conf.set('WITH_STORAGE_ZFS', 1)
-      foreach name : [ 'zfs', 'zpool' ]
-        conf.set_quoted(name.to_upper(), get_variable('@0@_prog'.format(name)).path())
-      endforeach
-    endif
+    use_storage = true
+    conf.set('WITH_STORAGE_ZFS', 1)
+    foreach name : [ 'zfs', 'zpool' ]
+      prog_var = get_variable('@0@_prog'.format(name))
+      if prog_var.found()
+        prog_path = prog_var.path()
+      else
+        prog_path = name
+      endif
+      conf.set_quoted(name.to_upper(), prog_path)
+    endforeach
   endif
 endif