]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Consistently use exit_monitor in qemuMigrationRun
authorJiri Denemark <jdenemar@redhat.com>
Thu, 19 Oct 2017 12:22:53 +0000 (14:22 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Mon, 23 Oct 2017 08:08:29 +0000 (10:08 +0200)
Almost every failure in qemuMigrationRun while we are talking to QEMU
monitor results in a jump to exit_monitor label. The only exception is
removed by this patch.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_migration.c

index 276d7d8f2559bfaf83333d50112d9e56fe9511ce..bcb0e2a987965548dc17c7cd9c5d9b72ed0c1c59 100644 (file)
@@ -3770,12 +3770,11 @@ qemuMigrationRun(virQEMUDriverPtr driver,
         /* explicitly do this *after* we entered the monitor,
          * as this is a critical section so we are guaranteed
          * priv->job.abortJob will not change */
-        ignore_value(qemuDomainObjExitMonitor(driver, vm));
         priv->job.current->status = QEMU_DOMAIN_JOB_STATUS_CANCELED;
         virReportError(VIR_ERR_OPERATION_ABORTED, _("%s: %s"),
                        qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
                        _("canceled by client"));
-        goto error;
+        goto exit_monitor;
     }
 
     if (qemuMonitorSetMigrationSpeed(priv->mon, migrate_speed) < 0)