]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: nxp: imx8-isi: Remove redundant check for dma_set_mask_and_coherent()
authorFrank Li <Frank.Li@nxp.com>
Thu, 22 May 2025 17:56:43 +0000 (13:56 -0400)
committerHans Verkuil <hverkuil@xs4all.nl>
Wed, 18 Jun 2025 07:21:59 +0000 (09:21 +0200)
dma_set_mask_and_coherent() never return failure when mask bigger than
32bit.

See commit f7ae20f2fc4e ("docs: dma: correct dma_set_mask() sample code")

So remove return value check for dma_set_mask_and_coherent().

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250522-8qxp_camera-v5-5-d4be869fdb7e@nxp.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c

index 015350c6f27845d3d93bed8a16fbead32597dcd6..073ea5912de3b41a20c6b8e51902375c495e07b4 100644 (file)
@@ -444,11 +444,7 @@ static int mxc_isi_probe(struct platform_device *pdev)
        }
 
        dma_size = isi->pdata->has_36bit_dma ? 36 : 32;
-       ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));
-       if (ret) {
-               dev_err(dev, "failed to set DMA mask\n");
-               return ret;
-       }
+       dma_set_mask_and_coherent(dev, DMA_BIT_MASK(dma_size));
 
        pm_runtime_enable(dev);