]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xhci: dbgtty: fix device unregister: fixup
authorŁukasz Bartosik <ukaszb@chromium.org>
Thu, 27 Nov 2025 11:16:44 +0000 (11:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Dec 2025 13:48:42 +0000 (14:48 +0100)
This fixup replaces tty_vhangup() call with call to
tty_port_tty_vhangup(). Both calls hangup tty device
synchronously however tty_port_tty_vhangup() increases
reference count during the hangup operation using
scoped_guard(tty_port_tty).

Cc: stable <stable@kernel.org>
Fixes: 1f73b8b56cf3 ("xhci: dbgtty: fix device unregister")
Signed-off-by: Łukasz Bartosik <ukaszb@chromium.org>
Link: https://patch.msgid.link/20251127111644.3161386-1-ukaszb@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-dbgtty.c

index 57cdda4e09c8ea74d3810e8009e2010a181efa19..90282e51e23ec04149a0a49b66ede3bffe96344d 100644 (file)
@@ -554,7 +554,7 @@ static void xhci_dbc_tty_unregister_device(struct xhci_dbc *dbc)
         * Hang up the TTY. This wakes up any blocked
         * writers and causes subsequent writes to fail.
         */
-       tty_vhangup(port->port.tty);
+       tty_port_tty_vhangup(&port->port);
 
        tty_unregister_device(dbc_tty_driver, port->minor);
        xhci_dbc_tty_exit_port(port);