]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
libcgroup: Segfault when we run setuid testcase without argument
authorDhaval Giani <dhaval@linux.vnet.ibm.com>
Sun, 14 Dec 2008 04:35:46 +0000 (04:35 +0000)
committerDhaval Giani <dhaval@linux.vnet.ibm.com>
Sun, 14 Dec 2008 04:35:46 +0000 (04:35 +0000)
From: "Rishikesh K. Rajak" <risrajak@linux.vnet.ibm.com>

In libcgroup testcase "setuid" testcase segfault when we run without uid
parameter.
This patch fixes the issue.

[dhaval@linux.vnet.ibm.com: Minor fixes]
Signed-off-by: Rishikesh k Rajak <risrajak@linux.vnet.ibm.com>
Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
git-svn-id: https://libcg.svn.sourceforge.net/svnroot/libcg/trunk@235 4f4bb910-9a46-0410-90c8-c897d4f1cd53

tests/setuid.c

index 9d77850b4754b0517614d842a4e88f397e286156..772de94f3c74439f7892c228c37448419a4b59ce 100644 (file)
@@ -43,6 +43,11 @@ int main(int argc, char *argv[])
        /* Return codes */
        int ret;
 
+       if (argc < 2) {
+               printf("Usage: %s <uid_value> \n", argv[0]);
+               goto finished;
+       }
+
        pwd = getpwnam(argv[1]);
        uid = pwd->pw_uid;
        fprintf(stdout, "Setting UID to %s (%d).\n", pwd->pw_name, uid);