]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: shaper: add a note that we expect cap dumps to be tiny
authorJakub Kicinski <kuba@kernel.org>
Tue, 9 Jun 2026 18:32:24 +0000 (11:32 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 11 Jun 2026 10:55:23 +0000 (12:55 +0200)
Various AI scan tools may complain that we don't support resuming
the cap dump. This is true, but the cap dumps are tiny.
net_shaper_nl_cap_pre_dumpit() sets up the dump for just
one device, so the size of the dump scales with NET_SHAPER_SCOPE_MAX (3).

We don't expect them to ever need more than a 4kB page.
Document this.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20260609183224.1108521-5-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/shaper/shaper.c

index 5a3b44c5d10f6375d1ab9e8f26124dc269d41f00..b65b356da16b359f8a31c6661cbd73a2589eabb5 100644 (file)
@@ -1452,6 +1452,8 @@ int net_shaper_nl_cap_get_dumpit(struct sk_buff *skb,
 
                ret = net_shaper_cap_fill_one(skb, binding, scope, flags,
                                              info);
+               /* cap dumps are tiny, we expect them to fit in a single skb */
+               WARN_ON_ONCE(ret == -EMSGSIZE);
                if (ret)
                        return ret;
        }