libcli/security: Cast isupper() argument to ‘unsigned char’

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index 022d20917b2ab2f14c0108b3829925d09f051de9..ec0dac765a19ec5b500f85bbf212d129e2a53c90 100644 (file)
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -555,7 +555,7 @@ static struct security_acl *sddl_decode_acl(struct security_descriptor *sd,
        if (acl == NULL) return NULL;
        acl->revision = SECURITY_ACL_REVISION_ADS;
 
-       if (isupper(sddl[0]) && sddl[1] == ':') {
+       if (isupper((unsigned char)sddl[0]) && sddl[1] == ':') {
                /* its an empty ACL */
                return acl;
        }