]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Avoid crash when LXC start fails with no interface target
authorDaniel P. Berrange <berrange@redhat.com>
Fri, 23 Nov 2012 16:36:52 +0000 (16:36 +0000)
committerCole Robinson <crobinso@redhat.com>
Sun, 9 Dec 2012 21:53:39 +0000 (16:53 -0500)
If the <interface> device did not contain any <target>
element, LXC would crash on a NULL pointer if starting
the container failed

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
(cherry picked from commit 68dceb635d8d8f68e36caf4054c32f0f9cb13c22)

src/lxc/lxc_process.c

index 079bc3abc47a7f77a527aa1d3937d299e1b2fc64..70513c2e83fb4cc189f8d1b7abebe863a568eda7 100644 (file)
@@ -254,7 +254,8 @@ static void virLXCProcessCleanup(virLXCDriverPtr driver,
     for (i = 0 ; i < vm->def->nnets ; i++) {
         virDomainNetDefPtr iface = vm->def->nets[i];
         vport = virDomainNetGetActualVirtPortProfile(iface);
-        ignore_value(virNetDevSetOnline(iface->ifname, false));
+        if (iface->ifname)
+            ignore_value(virNetDevSetOnline(iface->ifname, false));
         if (vport && vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH)
             ignore_value(virNetDevOpenvswitchRemovePort(
                             virDomainNetGetActualBridgeName(iface),