]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: arizona: use new line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 3 Mar 2025 13:18:36 +0000 (14:18 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 10 Mar 2025 10:52:13 +0000 (11:52 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20250303-gpiochip-set-conversion-v1-11-1d5cceeebf8b@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-arizona.c

index c15fda99120a9f5b7eea5be21742712ff57d1e44..e530c94dcce8d0b2c219c4ed3186891d8b5ec64d 100644 (file)
@@ -121,7 +121,8 @@ static int arizona_gpio_direction_out(struct gpio_chip *chip,
                                  ARIZONA_GPN_DIR | ARIZONA_GPN_LVL, value);
 }
 
-static void arizona_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
+static int arizona_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                           int value)
 {
        struct arizona_gpio *arizona_gpio = gpiochip_get_data(chip);
        struct arizona *arizona = arizona_gpio->arizona;
@@ -129,8 +130,8 @@ static void arizona_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
        if (value)
                value = ARIZONA_GPN_LVL;
 
-       regmap_update_bits(arizona->regmap, ARIZONA_GPIO1_CTRL + offset,
-                          ARIZONA_GPN_LVL, value);
+       return regmap_update_bits(arizona->regmap, ARIZONA_GPIO1_CTRL + offset,
+                                 ARIZONA_GPN_LVL, value);
 }
 
 static const struct gpio_chip template_chip = {
@@ -139,7 +140,7 @@ static const struct gpio_chip template_chip = {
        .direction_input        = arizona_gpio_direction_in,
        .get                    = arizona_gpio_get,
        .direction_output       = arizona_gpio_direction_out,
-       .set                    = arizona_gpio_set,
+       .set_rv                 = arizona_gpio_set,
        .can_sleep              = true,
 };