]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
remoteproc: qcom_q6v5_mss: Re-order writes to the IMEM region
authorSibi Sankar <quic_sibis@quicinc.com>
Mon, 19 Aug 2024 07:30:20 +0000 (13:00 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 14 Dec 2024 18:51:07 +0000 (19:51 +0100)
[ Upstream commit 7b22b7719fc17d5979a991c918c868ab041be5c8 ]

Any write access to the IMEM region when the Q6 is setting up XPU
protection on it will result in a XPU violation. Fix this by ensuring
IMEM writes related to the MBA post-mortem logs happen before the Q6
is brought out of reset.

Fixes: 318130cc9362 ("remoteproc: qcom_q6v5_mss: Add MBA log extraction support")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20240819073020.3291287-1-quic_sibis@quicinc.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/remoteproc/qcom_q6v5_mss.c

index 93eefefd514c7277330b108d2dfe6f6cfb6cf74d..7fe1f2c5480af1900128f7a79826fe31739e17a0 100644 (file)
@@ -1003,6 +1003,9 @@ static int q6v5_mba_load(struct q6v5 *qproc)
                goto disable_active_clks;
        }
 
+       if (qproc->has_mba_logs)
+               qcom_pil_info_store("mba", qproc->mba_phys, MBA_LOG_SIZE);
+
        writel(qproc->mba_phys, qproc->rmb_base + RMB_MBA_IMAGE_REG);
        if (qproc->dp_size) {
                writel(qproc->mba_phys + SZ_1M, qproc->rmb_base + RMB_PMI_CODE_START_REG);