]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
driver core: fw_devlink: Don't warn about sync_state() pending
authorUlf Hansson <ulf.hansson@linaro.org>
Tue, 7 Oct 2025 09:43:12 +0000 (11:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Oct 2025 07:47:40 +0000 (09:47 +0200)
Due to the wider deployment of the ->sync_state() support, for PM domains
for example, we are receiving reports about the sync_state() pending
message that is being logged in fw_devlink_dev_sync_state(). In particular
as it's printed at the warning level, which is questionable.

Even if it certainly is useful to know that the ->sync_state() condition
could not be met, there may be nothing wrong with it. For example, a driver
may be built as module and are still waiting to be initialized/probed. For
this reason let's move to the info level for now.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: Sebin Francis <sebin.francis@ti.com>
Reported-by: Diederik de Haas <didi.debian@cknow.org>
Reported-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Acked-by: Saravana Kannan <saravanak@google.com>
Reviewed-by: Sebin Francis <sebin.francis@ti.com>
Tested-by: Sebin Francis <sebin.francis@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c

index 3c533dab8fa530066f5ee6c5b351e86ba34cfc37..f69dc9c8595455d85bf7eda5d4abce1ed7cb5166 100644 (file)
@@ -1784,7 +1784,7 @@ static int fw_devlink_dev_sync_state(struct device *dev, void *data)
                return 0;
 
        if (fw_devlink_sync_state == FW_DEVLINK_SYNC_STATE_STRICT) {
-               dev_warn(sup, "sync_state() pending due to %s\n",
+               dev_info(sup, "sync_state() pending due to %s\n",
                         dev_name(link->consumer));
                return 0;
        }