phy: freescale: imx8m-pcie: Simplify with dev_err_probe()

Error handling in probe() can be a bit simpler with dev_err_probe().

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Link: https://lore.kernel.org/r/20250429090152.1094243-1-alexander.stein@ew.tq-group.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index 7355d9921b6467d6dd32a7893f5d4c44307b3652..68fcc8114d750a35c35eff5a71931bf3c94ffbef 100644 (file)
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -238,24 +238,21 @@ static int imx8_pcie_phy_probe(struct platform_device *pdev)
                imx8_phy->clkreq_unused = false;
 
        imx8_phy->clk = devm_clk_get(dev, "ref");
-       if (IS_ERR(imx8_phy->clk)) {
-               dev_err(dev, "failed to get imx pcie phy clock\n");
-               return PTR_ERR(imx8_phy->clk);
-       }
+       if (IS_ERR(imx8_phy->clk))
+               return dev_err_probe(dev, PTR_ERR(imx8_phy->clk),
+                                    "failed to get imx pcie phy clock\n");
 
        /* Grab GPR config register range */
        imx8_phy->iomuxc_gpr =
                 syscon_regmap_lookup_by_compatible(imx8_phy->drvdata->gpr);
-       if (IS_ERR(imx8_phy->iomuxc_gpr)) {
-               dev_err(dev, "unable to find iomuxc registers\n");
-               return PTR_ERR(imx8_phy->iomuxc_gpr);
-       }
+       if (IS_ERR(imx8_phy->iomuxc_gpr))
+               return dev_err_probe(dev, PTR_ERR(imx8_phy->iomuxc_gpr),
+                                    "unable to find iomuxc registers\n");
 
        imx8_phy->reset = devm_reset_control_get_exclusive(dev, "pciephy");
-       if (IS_ERR(imx8_phy->reset)) {
-               dev_err(dev, "Failed to get PCIEPHY reset control\n");
-               return PTR_ERR(imx8_phy->reset);
-       }
+       if (IS_ERR(imx8_phy->reset))
+               return dev_err_probe(dev, PTR_ERR(imx8_phy->reset),
+                                    "Failed to get PCIEPHY reset control\n");
 
        if (imx8_phy->drvdata->variant == IMX8MP) {
                imx8_phy->perst =