]> git.ipfire.org Git - thirdparty/coreutils.git/commitdiff
maint: tweak sc_check-I18N-AUTHORS
authorJim Meyering <jim@meyering.net>
Thu, 25 Oct 2012 16:35:34 +0000 (18:35 +0200)
committerJim Meyering <jim@meyering.net>
Thu, 25 Oct 2012 16:35:34 +0000 (18:35 +0200)
* cfg.mk (sc_check-I18N-AUTHORS): Remove unnecessary subshell;
add a self-explanatory diagnostic.

cfg.mk

diff --git a/cfg.mk b/cfg.mk
index 40ece55d33fbfd2c1750d0db0f00c541305508ec..08f6c3d821c4944d01a65b4dadc180db00a3dfec 100644 (file)
--- a/cfg.mk
+++ b/cfg.mk
@@ -181,13 +181,15 @@ sc_check-AUTHORS: $(all_programs)
          && diff $(au_actual) $(au_dotdot) \
          && rm -f $(au_actual) $(au_dotdot)
 
-# Ensure programs with authors with non ASCII names link with LIBICONV
+# Each program with a non-ASCII author name must link with LIBICONV.
 sc_check-I18N-AUTHORS:
-       @(cd $(srcdir)/src &&                           \
+       @cd $(srcdir)/src &&                                            \
          for i in $$(git grep -l -w proper_name_utf8 *.c|sed 's/\.c//'); do \
-           grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk > \
-             /dev/null || { echo FAIL $$i; exit 1; };            \
-         done)
+           grep -E "^src_$${i}_LDADD"' .?= .*\$$\(LIBICONV\)' local.mk \
+               > /dev/null                                             \
+             || { "echo $(ME): link rules for $$i do not include"      \
+                   '$$(LIBICONV)' 1>&2; exit 1; };                     \
+         done
 
 # Look for lines longer than 80 characters, except omit:
 # - program-generated long lines in diff headers,