]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
i3c: master: svc: Flush FIFO before sending Dynamic Address Assignment(DAA)
authorFrank Li <Frank.Li@nxp.com>
Wed, 29 Jan 2025 16:22:50 +0000 (11:22 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:40:12 +0000 (14:40 +0200)
[ Upstream commit a892ee4cf22a50e1d6988d0464a9a421f3e5db2f ]

Ensure the FIFO is empty before issuing the DAA command to prevent
incorrect command data from being sent. Align with other data transfers,
such as svc_i3c_master_start_xfer_locked(), which flushes the FIFO before
sending a command.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20250129162250.3629189-1-Frank.Li@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i3c/master/svc-i3c-master.c

index cf0550c6e95f0e0756775671637b0dea8113a05f..8cf3aa800d89d9065e2149715e91f439ad8518e6 100644 (file)
@@ -833,6 +833,8 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master,
        u32 reg;
        int ret, i;
 
+       svc_i3c_master_flush_fifo(master);
+
        while (true) {
                /* Enter/proceed with DAA */
                writel(SVC_I3C_MCTRL_REQUEST_PROC_DAA |