]> git.ipfire.org Git - thirdparty/open-vm-tools.git/commitdiff
Add a Coverity annotation to lib/vmGuestLib/vmGuestLib.c
authorOliver Kurth <okurth@vmware.com>
Mon, 30 Sep 2019 23:24:27 +0000 (16:24 -0700)
committerOliver Kurth <okurth@vmware.com>
Mon, 30 Sep 2019 23:24:27 +0000 (16:24 -0700)
A previous change adding Coverity annotations to vmGuestLib.c
omitted one.  Adding for completeness although it does not actually
affect Coverity results.

open-vm-tools/libguestlib/vmGuestLib.c

index e7f7795319f857d1d3552e2569438c771ec9a516..5cf0c811a026d5f690c0f9d5fc17e8999e4db8c5 100644 (file)
@@ -1837,6 +1837,12 @@ VMGuestLibIoctl(const GuestLibIoctlParam *param,
    }
    if (!DynXdr_AppendRaw(&xdrs, request, strlen(request)) ||
        !xdr_GuestLibIoctlParam(&xdrs, (GuestLibIoctlParam *)param)) {
+
+      /*
+       * DynXdr_Destroy only tries to free storage returned by a call to
+       * DynXdr_Create(NULL).
+       */
+      /* coverity[address_free] */
       DynXdr_Destroy(&xdrs, TRUE);
       return FALSE;
    }